Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logging config and move to module logging #31

Open
kzecchini opened this issue Dec 4, 2019 · 0 comments
Open

remove logging config and move to module logging #31

kzecchini opened this issue Dec 4, 2019 · 0 comments

Comments

@kzecchini
Copy link
Contributor

Right now, a logging.basicConfig is defined in primrose.__init__.py. The logging should be set up in the main module, not in the primrose package init.

Additionally, primrose uses the root logger for all statements. Since we are a package, I think using module logging is more appropriate: logger = logging.getLogger(__name__)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants