Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the block of $KAFKA_HEAP_OPTS from start-kafka.sh #547

Open
thangola opened this issue Nov 29, 2019 · 1 comment
Open

Remove the block of $KAFKA_HEAP_OPTS from start-kafka.sh #547

thangola opened this issue Nov 29, 2019 · 1 comment

Comments

@thangola
Copy link

if [[ -n "$KAFKA_HEAP_OPTS" ]]; then
    sed -r -i 's/(export KAFKA_HEAP_OPTS)="(.*)"/\1="'"$KAFKA_HEAP_OPTS"'"/g' "$KAFKA_HOME/bin/kafka-server-start.sh"
    unset KAFKA_HEAP_OPTS
fi

Since the official script kafka-server-start.sh already checks and well handles the environment variable KAFKA_HEAP_OPTS, the block above is redundant. I think it should be removed.

@sscaling
Copy link
Collaborator

in every version of kafka that we support? You can raise a PR - but would probably need to add a test case to automatically validate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants