Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix any kafkacat tests that rely on -e flag #451

Open
sscaling opened this issue Jan 24, 2019 · 2 comments
Open

Investigate and fix any kafkacat tests that rely on -e flag #451

sscaling opened this issue Jan 24, 2019 · 2 comments
Labels

Comments

@sscaling
Copy link
Collaborator

Currently the there are a set of tests that validate behaviour using kafkacat - they can be seen https://github.com/wurstmeister/kafka-docker/blob/master/test/docker-compose.yml#L34-L45.

They rely on kafkacat to stop consuming when the last offset is reached - however, in the confluentinc/cp-kafkacat:latest image, the behaviour has changed.

To unblock PRs, I have fixed the version to 5.0.0 which appears to work as expected. However, we should investigate why, raise an issue with the upstream repo if necessary, or fix the tests.

@sscaling sscaling added the bug label Jan 24, 2019
This was referenced Jan 24, 2019
@roadSurfer
Copy link

This would appear to be the underlying issue:
edenhill/kcat#86

@sscaling
Copy link
Collaborator Author

@roadSurfer - the change happened fairly recently. Looking at the recent changes (within a few months), this looks more suspect confluentinc/librdkafka@f561f2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants