Drupal 10 (drupal/core-dev) requires phpstan/extension-installer which breaks php_stan

[hkirsman]

phpstan/extension-installer starts to automatically include .neon files that are defined in our phpstan.neon.

You'll see that the scanner does not start and it says:

These files are included multiple times:
- /app/vendor/mglaman/phpstan-drupal/extension.neon
- /app/vendor/phpstan/phpstan-deprecation-rules/rules.neon

So in D10 the solution is to remove these lines:

This is where you see them being registered by phpstan/extension-installer

I'm just wondering if maybe we should make this permanent fix for also D9

• require phpstan/extension-installer in our composer.json
• remove the 2 lines

[hkirsman]

This is what I see my composer.lock atm:

{
            "name": "drupal/core-dev",
            "version": "10.0.9",
            "source": {
                "type": "git",
                "url": "https://github.com/drupal/core-dev.git",
                "reference": "22a053f9de0ce6ce9db2755693b9c81ddf86b3b7"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/drupal/core-dev/zipball/22a053f9de0ce6ce9db2755693b9c81ddf86b3b7",
                "reference": "22a053f9de0ce6ce9db2755693b9c81ddf86b3b7",
                "shasum": ""
            },
            "require": {
                "behat/mink": "^1.10",
                "behat/mink-browserkit-driver": "^2.1",
                "behat/mink-selenium2-driver": "^1.4",
                "composer/composer": "^2.4",
                "drupal/coder": "^8.3.10",
                "instaclick/php-webdriver": "^1.4.1",
                "justinrainbow/json-schema": "^5.2",
                "mglaman/phpstan-drupal": "^1.1.31",
                "mikey179/vfsstream": "^1.6.11",
                "phpspec/prophecy-phpunit": "^2",
                "phpstan/extension-installer": "^1.1",
                "phpstan/phpstan": "^1.10.1",
                "phpunit/phpunit": "^9.5",
                "symfony/browser-kit": "^6.2",
                "symfony/css-selector": "^6.2",
                "symfony/dom-crawler": "^6.2",
                "symfony/error-handler": "^6.2",
                "symfony/filesystem": "^6.2",
                "symfony/finder": "^6.2",
                "symfony/lock": "^6.2",
                "symfony/phpunit-bridge": "^6.2",
                "symfony/var-dumper": "^6.2"
            },
            "conflict": {
                "webflo/drupal-core-require-dev": "*"
            },
            "type": "metapackage",
            "notification-url": "https://packagist.org/downloads/",
            "license": [
                "GPL-2.0-or-later"
            ],
            "description": "require-dev dependencies from drupal/drupal; use in addition to drupal/core-recommended to run tests from drupal/core.",
            "support": {
                "source": "https://github.com/drupal/core-dev/tree/10.0.9"
            },
            "time": "2023-05-01T11:13:00+00:00"
        },

So I'll test and see how D9 behaves if Code Quality requires the same:

"phpstan/extension-installer": "^1.1",

[hkirsman]

Added the requirement and it installed fine on D9:

Now the config needed chaning also locally + the default configs needs changing in this repo.

Otherwise you get this:

[hkirsman]

Merged and created new release.