chore: skip node on duplicate field

Noroth · Noroth · commit 881ca363dc5e · 2025-11-25T12:56:32.000+01:00
diff --git a/v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor.go b/v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor.go
@@ -375,6 +375,7 @@ func (r *rpcPlanVisitor) EnterField(ref int) {
 	// prevent duplicate fields
 	fieldAlias := r.operation.FieldAliasString(ref)
 	if r.planInfo.currentResponseMessage.Fields.Exists(fieldName, fieldAlias) {
+		r.walker.SkipNode()
 		return
 	}
 
diff --git a/v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor_federation.go b/v2/pkg/engine/datasource/grpc_datasource/execution_plan_visitor_federation.go
@@ -346,7 +346,7 @@ func (r *rpcPlanVisitorFederation) EnterField(ref int) {
 	// prevent duplicate fields
 	fieldAlias := r.operation.FieldAliasString(ref)
 	if r.planInfo.currentResponseMessage.Fields.Exists(fieldName, fieldAlias) {
-		r.fieldPath = r.fieldPath.WithFieldNameItem([]byte{})
+		r.walker.SkipNode()
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -375,6 +375,7 @@ func (r *rpcPlanVisitor) EnterField(ref int) {`
`375`	`375`	`// prevent duplicate fields`
`376`	`376`	`fieldAlias := r.operation.FieldAliasString(ref)`
`377`	`377`	`if r.planInfo.currentResponseMessage.Fields.Exists(fieldName, fieldAlias) {`
	`378`	`+ r.walker.SkipNode()`
`378`	`379`	`return`
`379`	`380`	`}`
`380`	`381`
Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ func (r *rpcPlanVisitorFederation) EnterField(ref int) {`
`346`	`346`	`// prevent duplicate fields`
`347`	`347`	`fieldAlias := r.operation.FieldAliasString(ref)`
`348`	`348`	`if r.planInfo.currentResponseMessage.Fields.Exists(fieldName, fieldAlias) {`
`349`		`- r.fieldPath = r.fieldPath.WithFieldNameItem([]byte{})`
	`349`	`+ r.walker.SkipNode()`
`350`	`350`	`return`
`351`	`351`	`}`
`352`	`352`