chore: fix test

Author: Aenimus

composition-go/index.global.js

@@ -40,7 +40,7 @@ import { getEntriesNotInHashSet, getOrThrowError, kindToNodeType, numberToOrdina
 import { ImplementationErrors, InvalidEntityInterface, InvalidRequiredInputValueData } from '../utils/types';
 import { isFieldData } from '../schema-building/utils';
 import { printTypeNode } from '@graphql-tools/merge';
-import { NodeType, SubgraphName, TypeName } from '../types/types';
+import { NodeType, TypeName } from '../types/types';
 
 export const minimumSubgraphRequirementError = new Error('At least one subgraph is required for federation.');
 
@@ -346,7 +346,7 @@ export function incompatibleParentTypeMergeError({
   incomingNodeType,
   incomingSubgraphName,
 }: IncompatibleParentTypeMergeErrorParams): Error {
-  const existingSubgraphNames = new Array<SubgraphName>(...existingData.subgraphNames);
+  const existingSubgraphNames = [...existingData.subgraphNames];
   const nodeType = incomingNodeType ? `"${incomingNodeType}"` : interfaceObject;
   return new Error(
     ` "${existingData.name}" is defined using incompatible types across subgraphs.` +

composition/src/errors/errors.ts

@@ -2,7 +2,7 @@ import { readFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { EnumStatusCode } from '@wundergraph/cosmo-connect/dist/common/common_pb';
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, test, vi } from 'vitest';
-import { parse } from 'graphql';
+import { Kind, parse } from 'graphql';
 import { joinLabel } from '@wundergraph/cosmo-shared';
 import {
   FederationFailure,
@@ -19,8 +19,10 @@ import {
   noBaseDefinitionForExtensionError,
   noQueryRootTypeError,
   OBJECT,
+  ObjectDefinitionData,
   STRING_SCALAR,
 } from '@wundergraph/composition';
+import { SubgraphName } from '@wundergraph/composition/dist/types/types.js';
 import { composeSubgraphs } from '../src/core/composition/composition.js';
 import { afterAllSetup, beforeAllSetup, genID, genUniqueLabel } from '../src/core/test-util.js';
 import { ClickHouseClient } from '../src/core/clickhouse/index.js';
@@ -344,7 +346,17 @@ describe('Composition error tests', (ctx) => {
     const result = composeSubgraphs([subgraph1, subgraph2], LATEST_ROUTER_COMPATIBILITY_VERSION) as FederationFailure;
     expect(result.success).toBe(false);
     expect(result.errors).toHaveLength(1);
-    expect(result.errors[0]).toStrictEqual(incompatibleParentTypeMergeError('SameName', OBJECT, INTERFACE));
+    expect(result.errors).toStrictEqual([
+      incompatibleParentTypeMergeError({
+        existingData: {
+          name: 'SameName',
+          kind: Kind.OBJECT_TYPE_DEFINITION,
+          subgraphNames: new Set<SubgraphName>([subgraph1.name]),
+        } as ObjectDefinitionData,
+        incomingNodeType: INTERFACE,
+        incomingSubgraphName: subgraph2.name,
+      }),
+    ]);
   });
 
   test('that composition errors are returned if a type does not satisfy its implemented Interfaces after federation', () => {