-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkiaChart: Texts including axis labels, tooltips, toolbox and legend are not rendered. #174
Comments
use rnsvg or lower version of rnskia |
I switched to SvgChart and it worked, but is there any implication I should be aware of? Thank you. |
Yes, I'm aware. SvgCharts works but it's slow to respond to gestures. That's why I explicitly need SkiaChart to work. |
@nipunadodan yes I am having exactly same issue with you. |
@Jay2009 Below is what we've done as a workaround for now. It's not ideal but might help you (as long as you don't need react-native-skia for anything bar react-native-echarts on iOS). @shopify/react-native-skia 0.1.234 is the last version that will render text in react-native-echarts. That version will crash/lock up an iOS app on RN 0.73.8 (the version of RN we're using, I haven't tried 0.74.x yet) but seems to work fine on Android. We want Skia rendering for slow Android devices as it's faster than SVG rendering. The iOS devices will use SVG rendering for now (since they have generally stronger performance). How to set this up:
module.exports = {
dependencies: {
'@shopify/react-native-skia': {
platforms: {
ios: null
}
}
}
}
const SomeComponent = () => {
const PlatformSpecificChartTag = Platform.OS === 'ios' ? SvgChart : SkiaChart
return <PlatformSpecificChartTag option={...} etc />
} |
Now that react-native-skia have documented that text in ImageSVG tags is not going to be supported could we add that to the known issues on #16? |
I got the same issue, all Legend + Axises are blank, do we have a plan to fix that or is there a patch/hack in the meaning time ? |
We can't use it until we do a big refactoring, or
|
thankss @zhiqingchen , in our case we have to enable RN New Architect which is not supported by old version of Skia. Thanks @zhiqingchen again for your reply. |
I am working on the 2.x branch, and there has been some progress, but there is still a lot of work to be done. If you are interested, please review the code and provide me with some feedback. Rendered by skia above and rendered by svg below, skia also supports shadow, which is a nice feature. |
hi @zhiqingchen , how can i try the 2.x branch, i can test it for you. |
|
Hi @zhiqingchen ,
|
hi @zhiqingchen , any news on the version 2. Thanks. |
dev version sample code |
Following. Have the same problem. |
hi @anon-r-7 , did you follow the @zhiqingchen guide and have the same problem like me? |
Yeah, I mean the whole reason I chose echarts over victory was for performance with skia. If I'm back down to svg anyways I'm not sure what the win is. Naturally I cannot downgrade RN, if anything I need to upgrade RN. I'm optimistic that zhiqingchen will have a solution soon. I'm tentatively using svg renderer until then. |
hi @zhiqingchen , i able to run your 2.x example successfully, but it have some bug:
|
@ducpt-bili thanks. Please provide the code of the bug. |
hi @zhiqingchen , i just run the code in the example folder on 2.x branch, not add any thing new to it. |
hi @zhiqingchen , is there anything i can help for testing? |
#193 |
hi @zhiqingchen , thank you. Thank you again. |
try 2.0.0-canary.3 |
@zhiqingchen let me take a quick test. Thank you. |
I met this error below on ios simulator 17.4 when try 2.0.0-canary.3, with Skia chart. |
hi @zhiqingchen , i try out your repo and it work. Thank you. |
hi @zhiqingchen , so v2 is public release right? I will give it a try. |
yes, and expo snacks are ready too. |
Describe the bug
Texts including axis labels, tooltips, toolbox and legend are not rendered.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
Texts on axis labels, tooltips, legends and toolbox should be visible.
Screenshots
This is how it looks like when it is rendered using SkiaChart
This is how it is expected to look (screenshot taken after rendered using SVG)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Sample code: Github gist
The text was updated successfully, but these errors were encountered: