Skip to content

Commit

Permalink
ide: inline ide_dma_timeout() into ide_dma_timeout_retry()
Browse files Browse the repository at this point in the history
Since ide_dma_timeout() is only used by ide_dma_timeout_retry()
inline it there.

There should be no functional changes caused by this patch.

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
bzolnier committed Mar 31, 2009
1 parent 35c9b4d commit 1cee52d
Showing 1 changed file with 6 additions and 15 deletions.
21 changes: 6 additions & 15 deletions drivers/ide/ide-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -460,20 +460,6 @@ void ide_dma_lost_irq(ide_drive_t *drive)
}
EXPORT_SYMBOL_GPL(ide_dma_lost_irq);

static void ide_dma_timeout(ide_drive_t *drive)
{
ide_hwif_t *hwif = drive->hwif;

printk(KERN_ERR "%s: timeout waiting for DMA\n", drive->name);

if (hwif->dma_ops->dma_test_irq(drive))
return;

ide_dump_status(drive, "DMA timeout", hwif->tp_ops->read_status(hwif));

hwif->dma_ops->dma_end(drive);
}

/*
* un-busy the port etc, and clear any pending DMA status. we want to
* retry the current request in pio mode instead of risking tossing it
Expand All @@ -499,7 +485,12 @@ ide_startstop_t ide_dma_timeout_retry(ide_drive_t *drive, int error)
printk(KERN_WARNING "%s: DMA timeout retry\n", drive->name);
if (dma_ops->dma_clear)
dma_ops->dma_clear(drive);
ide_dma_timeout(drive);
printk(KERN_ERR "%s: timeout waiting for DMA\n", drive->name);
if (dma_ops->dma_test_irq(drive) == 0) {
ide_dump_status(drive, "DMA timeout",
hwif->tp_ops->read_status(hwif));
(void)dma_ops->dma_end(drive);
}
}

/*
Expand Down

0 comments on commit 1cee52d

Please sign in to comment.