Skip to content

Commit 9e1959c

Browse files
chore: Fix int - str comparison error in ios desired capabilities (appium#517)
if number >= PytestXdistWorker.COUNT: TypeError: '>=' not supported between instances of 'int' and 'str' 2. Updated test case path and iPhone model in Readme file
1 parent ba64adf commit 9e1959c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,18 +92,18 @@ $ pytest -n 2 test/unit
9292
### Functional
9393
9494
```
95-
$ pytest test/functional/ios/find_by_ios_class_chain_tests.py
95+
$ pytest test/functional/ios/search_context/find_by_ios_class_chain_tests.py
9696
```
9797
9898
### In parallel for iOS
99-
1. Create simulators named 'iPhone 6s - 8100' and 'iPhone 6s - 8101'
99+
1. Create simulators named 'iPhone 8 - 8100' and 'iPhone 8 - 8101'
100100
2. Install test libraries via pip
101101
```
102102
$ pip install pytest pytest-xdist
103103
```
104104
3. Run tests
105105
```
106-
$ pytest -n 2 test/functional/ios/find_by_ios_class_chain_tests.py
106+
$ pytest -n 2 test/functional/ios/search_context/find_by_ios_class_chain_tests.py
107107
```
108108
109109
# Release

test/functional/ios/helper/desired_capabilities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def gw(number):
5050
if PytestXdistWorker.COUNT is None:
5151
return '0'
5252

53-
if number >= PytestXdistWorker.COUNT:
53+
if number >= int(PytestXdistWorker.COUNT):
5454
return 'gw0'
5555

5656
return 'gw{}'.format(number)
@@ -65,7 +65,7 @@ def wda_port():
6565
return 8100
6666

6767

68-
# Before running tests, you must have iOS simulators named 'iPhone 6s - 8100' and 'iPhone 6s - 8101'
68+
# Before running tests, you must have iOS simulators named 'iPhone 8 - 8100' and 'iPhone 8 - 8101'
6969

7070

7171
def iphone_device_name(port=None):

0 commit comments

Comments
 (0)