Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying "title" even when not showing the label #9

Open
Robyer opened this issue Oct 6, 2019 · 0 comments
Open

Allow specifying "title" even when not showing the label #9

Robyer opened this issue Oct 6, 2019 · 0 comments

Comments

@Robyer
Copy link

Robyer commented Oct 6, 2019

Each icon's element should have title="{custom title}" tag. And input for this custom title should be visible in wp-admin even if "Show icons labels?" is unchecked.

Also I think I saw that icons has the alt="..." text, which was set to default name of the icon. It should be imho set to the same value as the title, because if plugin user chooses to use some icon for different service (e.g. use Skype icon for Steam - doesn't matter, just to explain this), it shouldn't "leak" that this icon is in fact Skype, it should say everywhere that it is "Steam" if user named the item that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant