Use rest_authorization_required_code instead of 403

Author: frozzare

src/endpoints/class-papi-rest-api-options-controller.php

@@ -24,7 +24,7 @@ public function delete_option( WP_REST_Request $request ) {
 			return (object) ['deleted' => true];
 		}
 
-		return new WP_Error( 'papi_delete_option_error', __( 'Delete option value did not work. The property may not be found', 'papi-rest-api' ), ['status' => 500] );
+		return new WP_Error( 'papi_delete_option_error', __( 'Delete option value did not work. The property may not be found.', 'papi-rest-api' ), ['status' => 500] );
 	}
 
 	/**
@@ -37,7 +37,7 @@ public function delete_option( WP_REST_Request $request ) {
 	public function delete_option_permissions_check( WP_REST_Request $request ) {
 		foreach ( $this->get_option_types_capabilities() as $capability ) {
 			if ( ! current_user_can( $capability ) ) {
-				return new WP_Error( 'papi_cannot_delete_option', __( 'Sorry, you are not allowed to delete the option value', 'papi-rest-api' ), ['status' => 403] );
+				return new WP_Error( 'papi_cannot_delete_option', __( 'Sorry, you are not allowed to delete the option value.', 'papi-rest-api' ), ['status' => rest_authorization_required_code()] );
 			}
 		}
 
@@ -85,7 +85,7 @@ protected function get_option_property( WP_REST_Request $request ) {
 		$property = $page->get_property( $request['slug'] );
 
 		if ( ! papi_is_property( $property ) ) {
-			return new WP_Error( 'papi_slug_invalid', __( 'Option slug doesn\'t exist', 'papi-rest-api' ) , ['status' => 404] );
+			return new WP_Error( 'papi_slug_invalid', __( 'Option slug doesn\'t exist.', 'papi-rest-api' ) , ['status' => 404] );
 		}
 
 		return $this->create_property_item( $request, $property, [
@@ -189,7 +189,7 @@ public function update_option( WP_REST_Request $request ) {
 			return $this->get_option_property( $request );
 		}
 
-		return new WP_Error( 'papi_update_option_error', __( 'Update option value did not work. The property may not be found', 'papi-rest-api' ), ['status' => 500] );
+		return new WP_Error( 'papi_update_option_error', __( 'Update option value did not work. The property may not be found.', 'papi-rest-api' ), ['status' => 500] );
 	}
 
 	/**
@@ -202,7 +202,7 @@ public function update_option( WP_REST_Request $request ) {
 	public function update_option_permissions_check( WP_REST_Request $request ) {
 		foreach ( $this->get_option_types_capabilities() as $capability ) {
 			if ( ! current_user_can( $capability ) ) {
-				return new WP_Error( 'papi_cannot_update_option', __( 'Sorry, you are not allowed to update the option value', 'papi-rest-api' ), ['status' => 403] );
+				return new WP_Error( 'papi_cannot_update_option', __( 'Sorry, you are not allowed to update the option value.', 'papi-rest-api' ), ['status' => rest_authorization_required_code()] );
 			}
 		}
 

tests/cases/endpoints/class-papi-rest-api-options-controller-test.php

@@ -32,8 +32,8 @@ public function test_delete_option_value_access_denied() {
 		$data = $response->get_data();
 		$expected = [
 			'code'    => 'papi_cannot_delete_option',
-			'message' => 'Sorry, you are not allowed to delete the option value',
-			'data'    => ['status' => 403]
+			'message' => 'Sorry, you are not allowed to delete the option value.',
+			'data'    => ['status' => 401]
 		];
 
 		$this->assertEquals( $expected, $data );
@@ -49,7 +49,7 @@ public function test_delete_option_value_error() {
 		$data = $response->get_data();
 		$expected = [
 			'code'    => 'papi_delete_option_error',
-			'message' => 'Delete option value did not work. The property may not be found',
+			'message' => 'Delete option value did not work. The property may not be found.',
 			'data'    => ['status' => 500]
 		];
 
@@ -105,7 +105,7 @@ public function test_get_missing_option_value() {
 		$data = $response->get_data();
 		$expected = [
 			'code'    => 'papi_slug_invalid',
-			'message' => 'Option slug doesn\'t exist',
+			'message' => 'Option slug doesn\'t exist.',
 			'data'    => ['status' => 404]
 		];
 
@@ -200,8 +200,8 @@ public function test_update_option_value_access_denied() {
 		$data = $response->get_data();
 		$expected = [
 			'code'    => 'papi_cannot_update_option',
-			'message' => 'Sorry, you are not allowed to update the option value',
-			'data'    => ['status' => 403]
+			'message' => 'Sorry, you are not allowed to update the option value.',
+			'data'    => ['status' => 401]
 		];
 
 		$this->assertEquals( $expected, $data );
@@ -218,7 +218,7 @@ public function test_update_option_value_error() {
 		$data = $response->get_data();
 		$expected = [
 			'code'    => 'papi_update_option_error',
-			'message' => 'Update option value did not work. The property may not be found',
+			'message' => 'Update option value did not work. The property may not be found.',
 			'data'    => ['status' => 500]
 		];