Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductAttribute null key error fixed. #91

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • Fixes null key error being through with attributeId is set to 0.
  • Adds a cacheable global ID as id. Just like with the VariationAttribute id field is not design for retrieval purposes although it can be use that way. It's true purpose is for caching.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels Jun 23, 2019
@kidunot89 kidunot89 self-assigned this Jun 23, 2019
@kidunot89 kidunot89 merged commit 1b1bb68 into wp-graphql:release-v0.1.2 Jun 23, 2019
@kidunot89 kidunot89 deleted the bugfix/variable-type-product-attributes branch June 23, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant