Skip to content

Conversation

@kidunot89
Copy link
Collaborator

…tations

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • WPGraphQL\Utils\Utils::get_database_id_from_id() now used to resolve IDs in edit/delete mutations for types inheriting the Node interface.
  • orderId field has been deprecated across all *order mutations.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

@kidunot89 kidunot89 merged commit 32f8ba2 into wp-graphql:develop Nov 6, 2024
13 of 15 checks passed
@kidunot89 kidunot89 added the bugfix Implements bugfix label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Implements bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant