Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add model classes to type configs to better support query analyzer ID tracking #874

Merged

Conversation

jasonbahl
Copy link
Collaborator

@jasonbahl jasonbahl commented Jul 3, 2024

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Resolves an issue cause friction between WooGraphQL and WPGraphQL Smart Cache usage.

It migrates all node types sourced from public WordPress CPTs to use post as the salt for Relay ID encryption. This fixes some issues with node identification and resolution for some plugins like WPGraphQL Smart Cache.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@jasonbahl jasonbahl requested a review from kidunot89 July 3, 2024 17:07
@jasonbahl jasonbahl self-assigned this Jul 3, 2024
@jasonbahl jasonbahl added the breaking change Solution will break some older solutions label Jul 3, 2024
@jasonbahl jasonbahl assigned kidunot89 and unassigned jasonbahl Jul 9, 2024
@jasonbahl
Copy link
Collaborator Author

@kidunot89 any update on this?

@kidunot89
Copy link
Member

@jasonbahl it should be just about ready to go. I think I got sidetracked with a bunch of stuff and didn't get it merged yet.

@kidunot89 kidunot89 force-pushed the fix/query-analyzer-model-tracking branch from c6b6d00 to caeeff9 Compare August 6, 2024 22:37
@kidunot89 kidunot89 merged commit 962410d into wp-graphql:develop Aug 6, 2024
15 checks passed
@kidunot89 kidunot89 added bugfix Implements bugfix and removed bugfix Implements bugfix labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Solution will break some older solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants