collectionStats query fully implemented
#849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
added
breaking change
justlevine
reviewed
May 7, 2024
| 'attribute' => [ | ||
| 'type' => 'String', | ||
| 'description' => __( 'Limit result set to products with a specific attribute. Use the taxonomy name/attribute slug.', 'wp-graphql-woocommerce' ), | ||
| 'type' => 'ProductAttributeEnum', |
There was a problem hiding this comment.
Changing the type makes this breaking for schemas already using it. If it's deprecated anyway is there a need to change the type as well?
There was a problem hiding this comment.
No, there isn't. Thanks for reminding me about the potential headache this will cause 🤣. I'll change it back before merging
justlevine
reviewed
May 7, 2024
| /** | ||
| * The instance of the class that helps filtering with the product attributes lookup table. | ||
| * | ||
| * @var Filterer |
There was a problem hiding this comment.
Suggested change
| * @var Filterer | |
| * @var \Automattic\WooCommerce\Internal\ProductAttributesLookup\Filterer |
Add |\stdClass ,if this prop is overloadable.
There was a problem hiding this comment.
It's not overloadable as fair as I know.
justlevine
reviewed
May 7, 2024
3 tasks
kidunot89
changed the title
collectionStats query fully implementedcollectionStats query fully implemented
kidunot89
changed the title
collectionStats query fully implementedcollectionStats query fully implemented
kidunot89
force-pushed
the
fix/wp-graphql-1.24.x-support
branch
from
c3e072e
to
e65ef93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
collectionStatsquery parametersattributesfield to the*ToProductUnionConnectionWhereArgsinput typesattributeandattributeTermon the*ToProductUnionConnectionWhereArgsinput typescollectionStatsquery andattributesfield functionality introduced in WooCommerce v3.9.0Does this close any currently open issues?
Resolves #845
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…
Where has this been tested?