fix: cleanup useless variables and ternaries #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
commented
Jul 11, 2023
| 'disabled' => $enable_auth_urls_hardcoded ? true : false, | ||
| 'sanitize_callback' => function( $value ) { | ||
| 'disabled' => $enable_auth_urls_hardcoded, | ||
| 'sanitize_callback' => static function( $value ) { |
There was a problem hiding this comment.
This is intentionally leaked to prevent merge conflicts with #764
justlevine
commented
Jul 11, 2023
| $item = \WC()->cart->get_cart_item( $payload['key'] ); | ||
|
|
||
| return $item; | ||
| 'resolve' => static function ( $payload ) { |
There was a problem hiding this comment.
This is intentionally leaked to prevent merge conflicts with #764
3 tasks
kidunot89
force-pushed
the
fix/cleanup-useless-variables
branch
from
36ad4ba to
30d43fa
Compare
kidunot89
added
the
dev-ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
This PR cleans up various useless variables and unnecessary ternaries from the codebase.
Branch is based off of #763, which should be merged first.
Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
Several unused variables remain in the codebase, where its unclear at a glance if their lack of use is intentional or a bug. They will be picked up by WPGraphQL Coding Standards and can be evaluated/removed/refactored separately.
Where has this been tested?