Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: update version requirements to what's actually needed by code #763

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

justlevine
Copy link
Contributor

@justlevine justlevine commented Jul 11, 2023

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

This PR updates the plugin headers with the versions of PHP, WordPress, and WooCommerce that this plugin actually supports. It additionally locks the stubs to those correct versions to prevent future breaking changes from leaking into the codebase accidentally.

(PHPstan was also updated to the latest version)

Note: This is marked as a breaking change, but technically this PR isnt actually causing any breaking behavior.

Update trace

Does this close any currently open issues?

Just local fatal errors when trying to upgrade on some old sites.

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

I'm sure work could be done to make the currently-breaking code backwards compatible, but since a) these breaks have been in the plugin for a while, and b) woocommerce itself has an L+2 support policy, I don't believe it's worth the effort.

Where has this been tested?

  • WooGraphQL Version: 0.14.1 ✅
  • WPGraphQL Version: 1.13.10❌, 1.14.0 ✅, 1.14.6 ✅
  • WordPress Version: 5.8.2 ❌ (WooCommerce wont activate), 5.9.7 ✅, 6.2.2 ✅
  • WooCommerce Version: 7.2.3 ❌ , 7.5 ✅, 7.8.2 ✅

Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, bro 👍🏿

@kidunot89 kidunot89 merged commit 23b744e into wp-graphql:develop Jul 19, 2023
@justlevine justlevine deleted the fix/required-versions branch July 19, 2023 20:38
@kidunot89 kidunot89 added the dev-ops PR resolves an issue or implements a feature related to the development process label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-ops PR resolves an issue or implements a feature related to the development process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants