fix!: update version requirements to what's actually needed by code #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
This PR updates the plugin headers with the versions of PHP, WordPress, and WooCommerce that this plugin actually supports. It additionally locks the stubs to those correct versions to prevent future breaking changes from leaking into the codebase accidentally.
(PHPstan was also updated to the latest version)
Note: This is marked as a breaking change, but technically this PR isnt actually causing any breaking behavior.
Update trace
OrderUtil
was only added in WC 7.0, and several codebase functions (e.g.model->dateCompleted
), rely on on WooCommerce 7.5.0.Does this close any currently open issues?
Just local fatal errors when trying to upgrade on some old sites.
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
I'm sure work could be done to make the currently-breaking code backwards compatible, but since a) these breaks have been in the plugin for a while, and b) woocommerce itself has an L+2 support policy, I don't believe it's worth the effort.
Where has this been tested?