Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auth no longer needed for the raw order totals #700

Merged

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Makes the Order type's RAW format available to guest users.

Does this close any currently open issues?

Fixes #685
Fixes #

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added the enhancement New feature or request label Jan 26, 2023
@kidunot89 kidunot89 self-assigned this Jan 26, 2023
},
'capability' => $this->post_type_object->cap->edit_posts,
],
'discountTotalRaw' => function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces must be used to indent lines; tabs are not allowed

},
'capability' => $this->post_type_object->cap->edit_posts,
],
'discountTotalRaw' => function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 space after FUNCTION keyword; 0 found

},
'capability' => $this->post_type_object->cap->edit_posts,
],
'discountTaxRaw' => function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces must be used to indent lines; tabs are not allowed

},
'capability' => $this->post_type_object->cap->edit_posts,
],
'discountTaxRaw' => function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 space after FUNCTION keyword; 0 found

},
'capability' => $this->post_type_object->cap->edit_posts,
],
'shippingTotalRaw' => function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces must be used to indent lines; tabs are not allowed

@codeclimate
Copy link

codeclimate bot commented Jan 26, 2023

Code Climate has analyzed commit a0c246d and detected 16 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 16

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.9% (0.0% change).

View more on Code Climate.

@kidunot89 kidunot89 merged commit 0a54ce9 into wp-graphql:develop Feb 1, 2023
@kidunot89 kidunot89 deleted the feat/order-raw-total-access branch February 1, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query order shippingTotal(format: RAW) return null even if requert is athenticated
1 participant