Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated method is_graphql_request #667

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

fabiojundev
Copy link
Contributor

Method WPGraphQL\Router::is_graphql_request to WPGraphQL\Router::is_graphql_http_request

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • [v] Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • [v] Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

This PR only changes one method to another the suggested one.
WPGraphQL\Router::is_graphql_request is deprecated since 0.4.1. Use Router::is_graphql_http_request instead.
https://github.com/wp-graphql/wp-graphql/blob/develop/src/Router.php#L220

Does this close any currently open issues?

No

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: 0.11.2
  • WPGraphQL Version: 1.12.2
  • WordPress Version: 6.1
  • WooCommerce Version: 7.1.0

@kidunot89 kidunot89 merged commit ddb5195 into wp-graphql:develop Dec 7, 2022
@kidunot89 kidunot89 added the bugfix Implements bugfix label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants