Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product variation attributes #130

Open
rotexhawk opened this issue Aug 23, 2019 · 11 comments · Fixed by #314
Open

Product variation attributes #130

rotexhawk opened this issue Aug 23, 2019 · 11 comments · Fixed by #314
Labels
design notes Blueprint and notes for coming feature enhancement New feature or request

Comments

@rotexhawk
Copy link

rotexhawk commented Aug 23, 2019

I am seeing two bugs with product attribute variations. The name field returns the wordpress field name. Maybe add Label Field as well? Also for sizes the value is empty.

With the current design I don't know if it's possible to build the default product page. See screenshot.

image

image

@rotexhawk
Copy link
Author

Maybe we can leave the current data as is and have an endpoint to get the list of all product attributes?

@kidunot89
Copy link
Member

kidunot89 commented Aug 26, 2019

I don't know if I would call this a bug. pa_color is the name of the taxonomy, and should probably the name of the attribute instead. The second attribute size isn't taxonomy based and the reason the value is "" is because a size value is assigned for that variation. However, I do think this should be null instead of "".

@kidunot89 kidunot89 added design notes Blueprint and notes for coming feature enhancement New feature or request labels Aug 26, 2019
@rotexhawk
Copy link
Author

Sounds good. I agree it's probably not a bug. For the second part, is it better to have a different query that will return a list of attributes with values or bake that into the same product query?

Right now I don't know what values to give to the size or color drop down.

@kidunot89
Copy link
Member

Hmm 🤔 , values for non-taxonomy atttributes are stored as a string value somewhere, in a format like this 'Yes|No|Maybe'. I'll have dig more into how to expose it to the schema.

@rotexhawk
Copy link
Author

Yeah, that might be a bit tricky. Honestly for version one, it will be easier to just return the values as they are entered/stored.

@kidunot89
Copy link
Member

@rotexhawk I think I stumbled on to the solution for this issue. The attributes and there options are stored on the parent product as well. If you run a cross-examination for any attributes on the variation with "" for the value, you can use the render a <select /> option or whatever using the data from the corresponding attribute or the parent Product

@kidunot89 kidunot89 pinned this issue Sep 25, 2019
@kidunot89 kidunot89 unpinned this issue Oct 12, 2019
@kidunot89
Copy link
Member

@rotexhawk Is this still an issue? I've long since lost track of reasoning for this issue.

@HiepVu511
Copy link
Contributor

I think we still need a label field. Right now there is no easy way to dynamically query that data

@travis-r6s
Copy link

Linked with #280

@Jommartinez
Copy link

I think we still need to be able to export the custom attributes of product variations. Has anyone solved it?

@eusouoviana
Copy link

+1 Still need this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design notes Blueprint and notes for coming feature enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants