Tell WordPress we support URL rewriting#92
Conversation
Summary of ChangesHello @ssnepenthe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial change to the development router configuration, enabling WordPress's native URL rewriting capabilities. By explicitly declaring support for URL rewriting, the change ensures that permalinks and other URL-dependent features within WordPress will function as expected in the development environment. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
There was a problem hiding this comment.
Code Review
This pull request correctly enables URL rewriting support for the built-in PHP server used by wp server. This is achieved by adding a got_url_rewrite filter, which will allow WordPress to use pretty permalinks. The change is straightforward and effective. I have one suggestion to improve code clarity by adding a comment.
| 20 | ||
| ); | ||
|
|
||
| add_filter( 'got_url_rewrite', '__return_true' ); |
There was a problem hiding this comment.
For consistency with other filters in this file (like the one for option_home) and for better readability, it would be helpful to add a comment explaining the purpose of this filter. This will make it clearer to future maintainers why this line is necessary.
// Tell WordPress we support URL rewriting, so that pretty permalinks work.
add_filter( 'got_url_rewrite', '__return_true' );
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Related: #89 |
See #91