Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more standard 'excludes' values #351

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Add more standard 'excludes' values #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc5e12c
Add more standard 'excludes' values
cliffordp Feb 5, 2023
9ce2756
exclude all starting with dot or underscore
cliffordp Feb 5, 2023
9e55c74
exclude all dot-files and '_entry'
cliffordp Feb 6, 2023
040b9e2
take out _entry
cliffordp Feb 6, 2023
a58468b
Add some tests for excludes values
danielbachhuber Feb 8, 2023
d9d1341
Remove Daniel's testing tag
danielbachhuber Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions features/makepot.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3785,3 +3785,84 @@ Feature: Generate a POT file of a WordPress project
"""
msgid "Other pattern description."
"""

Scenario: Ignores a standard set of directories as expected
Given an empty foo-plugin directory
And a foo-plugin/foo-plugin.php file:
"""
<?php
/**
* Plugin Name: Foo Plugin
* Plugin URI: https://example.com
* Description:
* Version: 0.1.0
* Author:
* Author URI:
* License: GPL-2.0+
* License URI: http://www.gnu.org/licenses/gpl-2.0.txt
* Text Domain: foo-plugin
* Domain Path: /languages
*/

__( 'foo-plugin/foo-plugin.php', 'foo-plugin' );
"""
And a foo-plugin/.git/foo-plugin.php file:
"""
<?php
__( 'foo-plugin/.git/foo-plugin.php', 'foo-plugin' );
"""
And a foo-plugin/not.git/foo-plugin.php file:
"""
<?php
__( 'foo-plugin/not.git/foo-plugin.php', 'foo-plugin' );
"""
And a foo-plugin/subdir/.git/foo-plugin.php file:
"""
<?php
__( 'foo-plugin/subdir/.git/foo-plugin.php', 'foo-plugin' );
"""
And a foo-plugin/subdir/not.git/foo-plugin.php file:
"""
<?php
__( 'foo-plugin/subdir/not.git/foo-plugin.php', 'foo-plugin' );
"""
And a foo-plugin/tests/foo-plugin.php file:
"""
<?php
__( 'foo-plugin/tests/foo-plugin.php', 'foo-plugin' );
"""
And a foo-plugin/longertests/foo-plugin.php file:
"""
<?php
__( 'foo-plugin/longertests/foo-plugin.php', 'foo-plugin' );
"""

When I run `wp i18n make-pot foo-plugin foo-plugin.pot`
Then the foo-plugin.pot file should contain:
"""
msgid "foo-plugin/foo-plugin.php"
"""
And the foo-plugin.pot file should not contain:
"""
msgid "foo-plugin/.git/foo-plugin.php"
"""
And the foo-plugin.pot file should contain:
"""
msgid "foo-plugin/not.git/foo-plugin.php"
"""
And the foo-plugin.pot file should not contain:
"""
msgid "foo-plugin/subdir/.git/foo-plugin.php"
"""
And the foo-plugin.pot file should contain:
"""
msgid "foo-plugin/subdir/not.git/foo-plugin.php"
"""
And the foo-plugin.pot file should not contain:
"""
msgid "foo-plugin/tests/foo-plugin.php"
"""
And the foo-plugin.pot file should contain:
"""
msgid "foo-plugin/longertests/foo-plugin.php"
"""
2 changes: 1 addition & 1 deletion src/MakePotCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class MakePotCommand extends WP_CLI_Command {
/**
* @var array
*/
protected $exclude = [ 'node_modules', '.git', '.svn', '.CVS', '.hg', 'vendor', 'Gruntfile.js', 'webpack.config.js', '*.min.js' ];
protected $exclude = [ 'node_modules', '.*', 'vendor', 'Gruntfile.js', 'webpack.config.js', '*.min.js', 'test', 'tests' ];

/**
* @var string
Expand Down