WP-CLI Themes: Added workaround to equalize folder naming conven… (#196)

WP-CLI Themes: Added workaround to equalize folder naming conventions across Win/Mac/Linux

Author: schlessera

features/theme.feature

@@ -543,3 +543,45 @@ Feature: Manage WordPress themes
        """
        active
        """
+
+  Scenario: Theme activation fails when slug does not match exactly
+    Given a WP install
+
+    When I run `wp theme install p2`
+    Then the return code should be 0
+
+    When I try `wp theme activate P2`
+    Then STDERR should contain:
+      """
+      Error: The 'P2' theme could not be found. Did you mean 'p2'?
+      """
+    And STDOUT should be empty
+    And the return code should be 1
+
+    When I try `wp theme activate p3`
+    Then STDERR should contain:
+      """
+      Error: The 'p3' theme could not be found. Did you mean 'p2'?
+      """
+    And STDOUT should be empty
+    And the return code should be 1
+
+    When I try `wp theme activate pb2`
+    Then STDERR should contain:
+      """
+      Error: The 'pb2' theme could not be found. Did you mean 'p2'?
+      """
+    And STDOUT should be empty
+    And the return code should be 1
+
+    When I try `wp theme activate completelyoff`
+    Then STDERR should contain:
+      """
+      Error: The 'completelyoff' theme could not be found.
+      """
+    And STDERR should not contain:
+      """
+      Did you mean
+      """
+    And STDOUT should be empty
+    And the return code should be 1

src/WP_CLI/Fetchers/Theme.php

@@ -2,6 +2,8 @@
 
 namespace WP_CLI\Fetchers;
 
+use WP_CLI\Utils;
+
 /**
  * Fetch a WordPress theme based on one of its attributes.
  */
@@ -19,13 +21,47 @@ class Theme extends Base {
 	 * @return object|false
 	 */
 	public function get( $name ) {
-		$theme = wp_get_theme( $name );
-
-		if ( ! $theme->exists() ) {
+		// Workaround to equalize folder naming conventions across Win/Mac/Linux.
+		// Returns false if theme stylesheet doesn't exactly match existing themes.
+		$existing_themes      = wp_get_themes( array( 'errors' => null ) );
+		$existing_stylesheets = array_keys( $existing_themes );
+		if ( ! in_array( $name, $existing_stylesheets, true ) ) {
+			$inexact_match = $this->find_inexact_match( $name, $existing_themes );
+			if ( false !== $inexact_match ) {
+				$this->msg .= sprintf( " Did you mean '%s'?", $inexact_match );
+			}
 			return false;
 		}
 
+		$theme = $existing_themes[ $name ];
+
 		return $theme;
 	}
+
+	/**
+	 * Find and return the key in $existing_themes that matches $name with
+	 * a case insensitive string comparison.
+	 *
+	 * @param string $name Name of theme received by command.
+	 * @param array  $existing_themes Key/value pair of existing themes, key is
+	 *                                a case sensitive name.
+	 * @return string|boolean Case sensitive name if match found, otherwise false.
+	 */
+	private function find_inexact_match( $name, $existing_themes ) {
+		$target = strtolower( $name );
+		$themes = array_map( 'strtolower', array_keys( $existing_themes ) );
+
+		if ( in_array( $target, $themes, true ) ) {
+			return $target;
+		}
+
+		$suggestion = Utils\get_suggestion( $target, $themes );
+
+		if ( '' !== $suggestion ) {
+			return $suggestion;
+		}
+
+		return false;
+	}
 }