Merge pull request #143 from austinginder/fix-90-plugin-update-reporting

🐛 FIX: Failed plugin updates not throwing errors

Author: schlessera

features/plugin-update.feature

@@ -191,3 +191,20 @@ Feature: Update WordPress plugins
       """
       Error: Can't find the requested plugin's version 2.5.4 in the WordPress.org plugin repository (HTTP code 404).
       """
+
+  @require-wp-4.7
+  Scenario: Plugin updates that error should not report a success
+    Given a WP install
+    And I run `wp plugin install --force akismet --version=4.0`
+    And I run `chmod -w wp-content/plugins/akismet`
+    And I try `wp plugin update akismet`
+    And save STDERR as {ERROR}
+    And I run `chmod +w wp-content/plugins/akismet`
+
+    And I run `echo "{ERROR}"`
+    Then STDOUT should contain:
+      """
+      Error: 
+      """
+
+    

features/plugin.feature

@@ -500,6 +500,7 @@ Feature: Manage WordPress plugins
       """
     And the return code should be 0
 
+  @require-wp-47
   Scenario: Plugin hidden by "all_plugins" filter
     Given a WP install
     And these installed and active plugins:

src/WP_CLI/CommandWithUpgrade.php

@@ -401,6 +401,9 @@ protected function update_many( $args, $assoc_args ) {
 						'new_version' => $info['update_version'],
 						'status' => $result[ $info['update_id'] ] !== null ? 'Updated' : 'Error',
 					);
+					if ( null === $result[ $info['update_id'] ] ) {
+						$errors++;
+					}
 				}
 
 				$format = 'table';