Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb #230

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb #230

merged 2 commits into from
Oct 13, 2022

Conversation

danielbachhuber
Copy link
Member

See #229

@danielbachhuber danielbachhuber self-assigned this Oct 12, 2022
@schlessera schlessera changed the title Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb Oct 13, 2022
@schlessera schlessera added this to the 2.0.23 milestone Oct 13, 2022
@schlessera schlessera added the bug label Oct 13, 2022
@schlessera
Copy link
Member

@danielbachhuber This is still in draft. Was there something else you wanted to add/change?

@danielbachhuber danielbachhuber marked this pull request as ready for review October 13, 2022 20:38
@danielbachhuber danielbachhuber requested a review from a team as a code owner October 13, 2022 20:38
@danielbachhuber
Copy link
Member Author

This is still in draft. Was there something else you wanted to add/change?

@schlessera Sorry, I forgot to flip the bit after I built the Phar.

@danielbachhuber danielbachhuber merged commit 0d9e365 into master Oct 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the 229-size-format-fail branch October 13, 2022 20:42
danielbachhuber added a commit that referenced this pull request Nov 18, 2022
@danielbachhuber
Fix PHP 8.1 fatal error with --orderby=size and --size_format=mb (#…
26f732d 
…230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

@danielbachhuber danielbachhuber

Labels
bug command:db command:db-size
Projects
None yet
Milestone
2.0.23
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @schlessera