Merge pull request php-curl-class#375 from zachborboa/master

Fix "Too many open files" error

Author: zachborboa

src/Curl/Curl.php

@@ -69,6 +69,7 @@ class Curl
     public $successFunction = null;
     public $errorFunction = null;
     public $completeFunction = null;
+    public $fileHandle = null;
 
     private $cookies = array();
     private $responseCookies = array();
@@ -336,12 +337,12 @@ public function error($callback)
     public function exec($ch = null)
     {
         $this->responseCookies = array();
-        if (!($ch === null)) {
-            $this->rawResponse = curl_multi_getcontent($ch);
-        } else {
+        if ($ch === null) {
             $this->call($this->beforeSendFunction);
             $this->rawResponse = curl_exec($this->curl);
             $this->curlErrorCode = curl_errno($this->curl);
+        } else {
+            $this->rawResponse = curl_multi_getcontent($ch);
         }
         $this->curlErrorMessage = curl_error($this->curl);
         $this->curlError = !($this->curlErrorCode === 0);

src/Curl/MultiCurl.php

@@ -7,7 +7,6 @@ class MultiCurl
     public $baseUrl = null;
     public $multiCurl;
     public $curls = array();
-    private $curlFileHandles = array();
     private $nextCurlId = 1;
     private $isStarted = false;
 
@@ -75,20 +74,23 @@ public function addDownload($url, $mixed_filename)
         $curl = new Curl();
         $curl->setURL($url);
 
+        // Use tmpfile() or php://temp to avoid "Too many open files" error.
         if (is_callable($mixed_filename)) {
             $callback = $mixed_filename;
             $curl->downloadCompleteFunction = $callback;
-            $fh = tmpfile();
+            $curl->fileHandle = tmpfile();
         } else {
             $filename = $mixed_filename;
-            $fh = fopen($filename, 'wb');
+            $curl->downloadCompleteFunction = function($instance, $fh) use ($filename) {
+                file_put_contents($filename, stream_get_contents($fh));
+            };
+            $curl->fileHandle = fopen('php://temp', 'wb');
         }
 
-        $curl->setOpt(CURLOPT_FILE, $fh);
+        $curl->setOpt(CURLOPT_FILE, $curl->fileHandle);
         $curl->setOpt(CURLOPT_CUSTOMREQUEST, 'GET');
         $curl->setOpt(CURLOPT_HTTPGET, true);
         $this->addHandle($curl);
-        $this->curlFileHandles[$curl->id] = $fh;
         return $curl;
     }
 
@@ -516,6 +518,10 @@ public function setUserAgent($user_agent)
      */
     public function start()
     {
+        if ($this->isStarted) {
+            return;
+        }
+
         foreach ($this->curls as $ch) {
             $this->initHandle($ch);
         }
@@ -536,9 +542,8 @@ public function start()
                             unset($this->curls[$key]);
 
                             // Close open file handles and reset the curl instance.
-                            if (isset($this->curlFileHandles[$ch->id])) {
-                                $ch->downloadComplete($this->curlFileHandles[$ch->id]);
-                                unset($this->curlFileHandles[$ch->id]);
+                            if (!($ch->fileHandle === null)) {
+                                $ch->downloadComplete($ch->fileHandle);
                             }
                             break;
                         }