Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a tiny error at output_builders.py : 70 #38

Closed
EliteWeapon opened this issue Jul 3, 2024 · 2 comments
Closed

There is a tiny error at output_builders.py : 70 #38

EliteWeapon opened this issue Jul 3, 2024 · 2 comments

Comments

@EliteWeapon
Copy link

{{A tiny error in output_builders}}

error location: src/iris/orchestration/output_builders.py : 70

Context

  • Firmware Version:
  • Operating System:
  • SDK version: v1.1.0
  • Toolchain version:

Expected Behavior

geometry_mask, noise_mask = (
    call_trace["segmentation_binarization"] if call_trace["segmentation_binarization"] is **not** None else (None, None)
)

Current Behavior

geometry_mask, noise_mask = (
    call_trace["segmentation_binarization"] if call_trace["segmentation_binarization"] is None else (None, None)
)

Failure Information (for bugs)

Steps to Reproduce

Failure Logs

@EliteWeapon EliteWeapon changed the title There is a tiny error in output_builders.py : 70 There is a tiny error at output_builders.py : 70 Jul 3, 2024
@TanguyJeanneau
Copy link
Contributor

Hi @EliteWeapon !

Thanks for noticing and raising this issue !
Yes you're right, there's indeed a typo here. This was noticed a few weeks ago and is fixed on dev, but the change isn't applied on main yet. We're releasing open-iris@v1.1.1 this week, you should have a fixed version by Friday EoD

How is your experience using open-iris so far, anything you'd like to see improved ? 🙂 open-iris has been open-sourced recently, so we're eager to get feedback on how we can make user's life better and our software more useful !

@EliteWeapon
Copy link
Author

Thank you much for your efforts and dedication. Due to open source, the application of iris recognition will become increasingly widespread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants