Skip to content

Miscellaneous WordPress-Develop update notes. #75984

@peterwilsoncc

Description

@peterwilsoncc

A few notes following a review of commits from the Gutenberg integrations, some of which I'll start a PR to cover myself.

Anyone with suitable permission should feel free to add to this list. It would be good to discuss any removals below and do so with strike outs.

  • wp-includes/build/pages/ generated files
    • Add a sourceURL comment to styles, referring to function/file name as required cc @westonruter for an assist
    • Use the Script API if possible: register a script handle with an empty URL and inline styles
    • Function defintions missing @since annotations
    • As noted by @desrosj elsewhere, these functions are in WP-Dev as pluggable functions and ought not to be.
  • block_core_page_list_get_submenu_visibility() incorrect since.
  • block_core_navigation_get_submenu_visibility() incorrect since.
  • block_core_navigation_link_render_submenu_icon() hard deprecated, potential fatal for third party devs
  • Existing hooks fired in *.php.template files should use /** ...documented in... */ docblocks

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Type] Code QualityIssues or PRs that relate to code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions