-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Open
Labels
[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality
Description
A few notes following a review of commits from the Gutenberg integrations, some of which I'll start a PR to cover myself.
Anyone with suitable permission should feel free to add to this list. It would be good to discuss any removals below and do so with strike outs.
wp-includes/build/pages/generated files- Add a sourceURL comment to styles, referring to function/file name as required cc @westonruter for an assist
- Use the Script API if possible: register a script handle with an empty URL and inline styles
- Function defintions missing
@sinceannotations - As noted by @desrosj elsewhere, these functions are in WP-Dev as pluggable functions and ought not to be.
-
block_core_page_list_get_submenu_visibility()incorrect since. -
block_core_navigation_get_submenu_visibility()incorrect since. -
block_core_navigation_link_render_submenu_icon()hard deprecated, potential fatal for third party devs - Existing hooks fired in
*.php.templatefiles should use/** ...documented in... */docblocks
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
[Type] Code QualityIssues or PRs that relate to code qualityIssues or PRs that relate to code quality