Skip to content

Conversation

@derekblank
Copy link
Contributor

@derekblank derekblank commented May 25, 2023

Release for Gutenberg Mobile 1.96.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Add disabled style to Cell component

Fix undo/redo history when inserting a link configured to open in a new tab

Disable details settings for not belonged VideoPress videos

Enable VideoPress block on Android

Tapping any type of nested block moves focus to the nested block directly, rather than requiring multiple taps to navigate down each nesting levels

List block - Fix merging nested list into paragraph

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@mokagio
Copy link
Contributor

mokagio commented May 25, 2023

@derekblank apologies for the Podfile.lock inconvenience.

image

I fixed the issue in https://github.com/wordpress-mobile/gutenberg-mobile/commits/1815c5fbcafd5a5c39f9d78b37530a2d755c17ab and updated the release automation so that this should not occur again, wordpress-mobile/release-toolkit-gutenberg-mobile#116

@derekblank derekblank marked this pull request as ready for review May 25, 2023 04:27
@derekblank derekblank added this to the 1.96.0 (22.5) milestone May 25, 2023
@fluiddot
Copy link
Contributor

Verify Items from test plan have been completed

I've unmarked this checkbox as the test plan hasn't been completed yet. Next Tuesday, we'll perform it.

Bundle package of the release is updated.

I checked the commits and confirmed that the bundle was updated, hence I'm marking this checkbox.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@derekblank derekblank merged commit c27524c into trunk May 26, 2023
@derekblank derekblank deleted the release/1.96.0 branch May 26, 2023 01:54
@SiobhyB
Copy link
Contributor

SiobhyB commented May 30, 2023

🟢 Writing Flow checklist (iOS)

Build: 22.5.0.0
Device: iPhone XR (iOS 16.5)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor

SiobhyB commented May 30, 2023

🟢 Unsupported Block Tests (iOS)

Build: 22.5.0.0
Device: iPhone XR (iOS 16.5)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@SiobhyB
Copy link
Contributor

SiobhyB commented May 30, 2023

🟢 Test Suite 2 (iOS)

Build: 22.5.0.0
Device: iPhone XR (iOS 16.5)

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - Deep nesting is possible (verify iOS does not crash) - TC001
  • Group - Check if Group placeholder is visible for the unselected state - TC002
  • Group - Check if Group placeholder is render in nested structure - TC003
  • Group - Nested block have proper border styling - TC004
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC005

Buttons-1

  • Buttons block - Button's wrapper grows properly - TC019
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC002
  • Buttons block - Wrapping Buttons - TC003

Button-2

  • Buttons block - Buttons alignment options - TC004
  • Buttons block - Settings: Open in new tab - TC007
  • Buttons block - Settings: Link rel - TC008

Button-3

  • Buttons block - Settings: Link URL - TC006
  • Buttons block - Settings: Remove link - TC010
  • Buttons block - Settings: Synchronize with button options - TC009

Color Settings - 1

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Drag and Drop Blocks - 1

  • Drag and Drop Blocks - Drag block to the top of the content - TC001
  • Drag and Drop Blocks - Drag block to the bottom of the content - TC002

VideoPress - 2

  • VideoPress block - Player - TC003
  • VideoPress block - Private video - TC005
  • VideoPress block - Upload limit for Free users - TC006

@geriux
Copy link
Contributor

geriux commented May 30, 2023

🟢 Writing Flow checklist (Android)

Build: 22.5-rc-1
Device: Samsung A23 5G (Android 13)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux
Copy link
Contributor

geriux commented May 30, 2023

⚪️ Unsupported Block Tests (Android)

Build: 22.5-rc-1
Device: Samsung A23 5G (Android 13)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@geriux
Copy link
Contributor

geriux commented May 30, 2023

⚪️ Test Suite 1 (Android)

Build: 22.5-rc-1
Device: Samsung Galaxy S20 FE 5G (Android 11)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

MediaText - 1

MediaText - 2

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • Active icon gets product color - TC001
  • Social icon forwarding to the link - TC002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants