Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobile editor preference switch on Atomic WP.com sites #3260

Open
guarani opened this issue Mar 15, 2021 · 5 comments
Open

Remove mobile editor preference switch on Atomic WP.com sites #3260

guarani opened this issue Mar 15, 2021 · 5 comments

Comments

@guarani
Copy link
Contributor

guarani commented Mar 15, 2021

Description

There is a mobile editor preference switch ("Use block editor" toggle switch in My Site → Settings) that allows site administrators to make the classic editor the default for all new content on that site. This issue tracks the need to remove that switch on Atomic WP.com sites, and by doing so, make the block editor the default on this type of site.
The exception to this is for the user flow where a post is created via the WordPress share extension, which will continue to use the classic editor.

To see the toggle switch

  1. Log into the app
  2. Choose an Atomic WP.com site you're an admin of
  3. Go to My Site → Settings and notice that there is a "Use block editor" toggle switch

What will change

  1. Site → Settings should no longer contain a "Use block editor" toggle switch
  2. New posts/pages should always use the block editor (except those created via the WPiOS share extension)

Screenshots

Smartphone (please complete the following information):

  • Device: Android or iOS
  • OS: any version
  • Version WP 16.5
@fluiddot
Copy link
Contributor

fluiddot commented Nov 25, 2021

@guarani if we remove the switch, we would need to force enable the block editor for those users that previously disabled it, right?

I see that at least on iOS, this value is persisted in the device (reference), so I guess we could also remove this logic, wdyt?

@guarani
Copy link
Contributor Author

guarani commented Nov 25, 2021

Thanks for asking, @fluiddot! I should have included more context here, but in short, we paused work on removing the switch for Atomic sites. This was because Atomic users use the Classic editor more than Simple site users do.

After we removed access to the Classic editor on Simple sites for all new posts (WPiOS PR here), we decided to revisit a few months down the road the same change on Atomic sites (see internal ref p9ugOq-1On-p2#comment-3595).

I'm not sure if we want to revisit this now, but if we do, it's probably part of a larger project (i.e. it won't involve only this issue).

@fluiddot
Copy link
Contributor

Thanks @guarani for the clarification 🙇 !

I was thinking to tackle this as part of the groundskeeping rotation, if this is on hold for now, I'll pick other issues.

@guarani
Copy link
Contributor Author

guarani commented Nov 25, 2021

I was thinking to tackle this as part of the groundskeeping rotation, if this is on hold for now, I'll pick other issues.

Makes sense 🙇

@SiobhyB
Copy link
Contributor

SiobhyB commented Jan 8, 2024

I'm going to go ahead to remove the [Pri] High label, with the following reasoning:

  • The block editor is the default editor for Atomic sites, so most users will only find this toggle if they go digging.
  • If we removed the toggle, Atomic users could still easily install the classic editor plugin in order to use the older editor.
  • This issue's been open for over two years now, which likely signifies this isn't super high priority for us. It'd still be nice to remove the toggle eventually, but it doesn't feel urgent.

Please feel welcome to comment and re-add the [Pri] High label if I've missed anything here!

@SiobhyB SiobhyB removed the [Pri] High label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants