Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Unsupported Block Editor offline experience #2483

Open
Tracked by #2358
guarani opened this issue Jul 11, 2020 · 3 comments
Open
Tracked by #2358

Improve the Unsupported Block Editor offline experience #2483

guarani opened this issue Jul 11, 2020 · 3 comments

Comments

@guarani
Copy link
Contributor

guarani commented Jul 11, 2020

Related: #2358

Describe the bug
The Unsupported Block Editor requires an internet connection to function, but does not provide any indication to the user if their internet connection is offline.

To Reproduce
Steps to reproduce the behavior:

  1. On the WordPress for iOS or Android apps, edit a post containing a block not currently supported by the mobile Block editor.
  2. Click the (?) button on the unsupported block placeholder
  3. Turn off the device's internet connection
  4. Tap the "Edit block in web browser" option in the bottom sheet that appeared in Step 2
  5. Notice the screen loads for a short time before staying blank, providing no indication that there is no internet connection

Expected behavior
Upon opening the Unsupported Block Editor, if there is no internet connection, the UI should communicate this is some way.

Screenshots

Blank screen shown when the Unsupported Block Editor is presented and there is no internet connection

Smartphone (please complete the following information):

  • Device: iPhone 7 or any other supported device
  • OS: iOS 14 or any other OS
  • Version: This feature is soon-to-be-released in WPiOS and WPAndroid version 15.3.
@hypest
Copy link
Contributor

hypest commented Jun 24, 2021

Now that we have the intermediate loading screen in place, I wonder if we could use it for notifying of no-network too. WDYT @guarani?

@guarani
Copy link
Contributor Author

guarani commented Jun 25, 2021

👋 @hypest, I agree this makes sense now that we have the loading screen in place.


@SiobhyB regarding the implementation, on iOS I'd go with using WPiOS' existing offline screen. Given our recent discussion about the differences between implementations on iOS and Android, I wanted to check that using this screen from the main apps is a good approach overall.
(I'm not suggesting we're necessarily going to work on this, just was curious about your opinion here given your recent work in this part of the app.)

@guarani
Copy link
Contributor Author

guarani commented Jun 25, 2021

iOS Android

These are the two offline screens I saw in the main app (they're not used everywhere though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants