Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss and implement common approach to show block icon on MobileToolbar #1942

Open
jbinda opened this issue Feb 21, 2020 · 9 comments
Open
Labels
Blocks [Status] Needs Design [Type] Enhancement Improves a current area of the editor

Comments

@jbinda
Copy link
Contributor

jbinda commented Feb 21, 2020

Is your feature request related to a problem? Please describe.
According to Slack discussion with @iamthomasbishop connected with block icons on MobileToolbar

Describe the solution you'd like
Show block icon in each block in MobileToolbar next to undo/redo icons. See example screen below

Describe alternatives you've considered
TBD

Additional context

@iamthomasbishop
Copy link
Contributor

For reference, I started writing documentation for the quick toolbar (which is the inserter + block toolbar + keyboard toggle button combined) over on our design docs:

@chipsnyder
Copy link
Contributor

I'm going through and reviewing some of the open issues on our boards to make sure I understand the current state.

@iamthomasbishop Is this still desired (although I assume a lower priority)? If so I can move it to another project or close it if we aren't focused on it anymore.

@iamthomasbishop
Copy link
Contributor

Is this still desired

@chipsnyder most definitely, and now(ish) would be a great time because I'd like to use it for block transforms (of which @illusaen is working on a v1). 😄

@chipsnyder
Copy link
Contributor

Awesome, thanks @iamthomasbishop, that sounds good to me.

@illusaen @mchowning Would it make sense to combine this with the block transform project then?

@illusaen
Copy link
Contributor

@chipsnyder Just to confirm, this is to show a non-pressable icon on the quick toolbar that tells users which block is currently selected, right?

@illusaen
Copy link
Contributor

Is this still desired

@chipsnyder most definitely, and now(ish) would be a great time because I'd like to use it for block transforms (of which @illusaen is working on a v1). 😄

@iamthomasbishop I gotta admit I'm a little confused on how this is related to transforms :) Should pressing this button bring up the transform menu? In that case, would it be confusing since some blocks wouldn't have transforms?

@iamthomasbishop
Copy link
Contributor

@illusaen Sorry, I should've been clearer. This would be a toolbar button that when tapped would trigger the transform UI that you're working on — essentially the same thing as the web UI, and it would replace the button in the ••• menu which I believe is what you currently have. This little thingy:

@illusaen
Copy link
Contributor

@iamthomasbishop I see, that makes sense! So if there were no transforms available for the selected block, would the button still be there but be disabled?

@iamthomasbishop
Copy link
Contributor

if there were no transforms available for the selected block, would the button still be there but be disabled?

@illusaen I think the general idea was that we should include an affordance like a dropdown arrow/icon that would give a hint of a dropdown menu. Then we could exclude the icon in cases where no transforms are available for a block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks [Status] Needs Design [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

No branches or pull requests

4 participants