-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss and implement common approach to show block icon on MobileToolbar #1942
Comments
For reference, I started writing documentation for the quick toolbar (which is the inserter + block toolbar + keyboard toggle button combined) over on our design docs: |
I'm going through and reviewing some of the open issues on our boards to make sure I understand the current state. @iamthomasbishop Is this still desired (although I assume a lower priority)? If so I can move it to another project or close it if we aren't focused on it anymore. |
@chipsnyder most definitely, and now(ish) would be a great time because I'd like to use it for block transforms (of which @illusaen is working on a v1). 😄 |
Awesome, thanks @iamthomasbishop, that sounds good to me. @illusaen @mchowning Would it make sense to combine this with the block transform project then? |
@chipsnyder Just to confirm, this is to show a non-pressable icon on the quick toolbar that tells users which block is currently selected, right? |
@iamthomasbishop I gotta admit I'm a little confused on how this is related to transforms :) Should pressing this button bring up the transform menu? In that case, would it be confusing since some blocks wouldn't have transforms? |
@illusaen Sorry, I should've been clearer. This would be a toolbar button that when tapped would trigger the transform UI that you're working on — essentially the same thing as the web UI, and it would replace the button in the |
@iamthomasbishop I see, that makes sense! So if there were no transforms available for the selected block, would the button still be there but be disabled? |
@illusaen I think the general idea was that we should include an affordance like a dropdown arrow/icon that would give a hint of a dropdown menu. Then we could exclude the icon in cases where no transforms are available for a block. |
Is your feature request related to a problem? Please describe.
According to Slack discussion with @iamthomasbishop connected with block icons on
MobileToolbar
Describe the solution you'd like
Show block icon in each block in
MobileToolbar
next to undo/redo icons. See example screen belowDescribe alternatives you've considered
TBD
Additional context
The text was updated successfully, but these errors were encountered: