Skip to content

Conversation

@alpavanoglu
Copy link
Contributor

This PR matches the strings to the Android Implementation

To test:

  • Enable Site Creation Feature Flag

Paid Domain

  • Install Jetpack and log in.
  • Head to "My Site" > "Chevron Down" button to display "My Sites" screen.
  • Tap "+" button, then "Create WordPress.com site"
  • Go through the flow until your reach the "Choose a domain" screen.
  • Search for a domain and select a PAID domain.
  • Tap "Create Site."
  • Title, description and footer should match to the strings in screenshot from Android PR linked above.

Free Domain

  • Install Jetpack and log in.
  • Head to "My Site" > "Chevron Down" button to display "My Sites" screen.
  • Tap "+" button, then "Create WordPress.com site"
  • Go through the flow until your reach the "Choose a domain" screen.
  • Search for a domain and select a FREE domain.
  • Tap "Create Site."
  • Title, description and footer should match to the strings in screenshot from Android PR linked above.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@alpavanoglu alpavanoglu added this to the 22.3 milestone Apr 26, 2023
@alpavanoglu alpavanoglu requested a review from salimbraksa April 26, 2023 13:36
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 26, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20610-e4e8d2f
Version22.2
Bundle IDcom.jetpack.alpha
Commite4e8d2f
App Center Buildjetpack-installable-builds #4629
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 26, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20610-e4e8d2f
Version22.2
Bundle IDorg.wordpress.alpha
Commite4e8d2f
App Center BuildWPiOS - One-Offs #5601
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa force-pushed the task/domain-purchase-final-ui-strings branch from f02006c to e4e8d2f Compare April 26, 2023 18:05
@salimbraksa salimbraksa changed the base branch from trunk to task/20079-site-creation-domains-checkout April 26, 2023 18:06
Base automatically changed from task/20079-site-creation-domains-checkout to trunk April 26, 2023 18:14
@alpavanoglu alpavanoglu deleted the task/domain-purchase-final-ui-strings branch April 27, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants