Skip to content

Turn on feature flag to the new Core Data context structure #19433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2022
Merged

Turn on feature flag to the new Core Data context structure #19433

merged 6 commits into from
Oct 18, 2022

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Oct 11, 2022 •
edited
Loading

All the known issues, which is listed below, of the new ContainerContextFactory have been fixed.

  1. Albums list keeps blinking #19266
  2. Media Picker collection shows incorrect thumbnail. Fixed in Fix incremental update MediaPicker-iOS#394
  3. Notifications list goes blank upon syncing an updated notification (i.e. the "Someone liked your post" notification). Fixed in Reimplement invaliding Notification attributes cache #19395.

Please note, this PR aims at 21.1 release, so that we have time to test the new context objects structure.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I have turned this feature flag on locally for a while, haven't notified any new issue.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@crazytonyli crazytonyli added the Core Data Issues related to Core Data label Oct 11, 2022
@crazytonyli crazytonyli added this to the 21.1 milestone Oct 11, 2022
@crazytonyli crazytonyli requested a review from mokagio October 11, 2022 21:50
@crazytonyli crazytonyli self-assigned this Oct 11, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 11, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19433-50ce1d1 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 11, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19433-50ce1d1 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@crazytonyli
Copy link
Contributor Author

crazytonyli commented Oct 17, 2022

@mokagio Do you mind having a look at this PR? I'd like to merge this sooner so that we can get a maximum amount of testing time. Thanks!

@mokagio mokagio mentioned this pull request Oct 18, 2022
Merged
mokagio
mokagio approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazytonyli sorry for the long wait. I've been meaning to open #19478 for a suggestion, but kept getting side tracked by other things.

Good to go 👍

@crazytonyli crazytonyli enabled auto-merge October 18, 2022 21:10
@crazytonyli crazytonyli merged commit 65d3f78 into trunk Oct 18, 2022
@crazytonyli crazytonyli deleted the turn-on-new-context-factory branch October 18, 2022 21:42
@twstokes twstokes mentioned this pull request Oct 25, 2022
Closed
@mokagio mokagio mentioned this pull request Dec 15, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mokagio mokagio mokagio approved these changes

Assignees

@crazytonyli crazytonyli

Labels

Core Data Issues related to Core Data

Projects

None yet

Milestone

21.1

Development

Successfully merging this pull request may close these issues.

4 participants

@crazytonyli @wpmobilebot @mokagio