Analysis: Resolve use check or error warning for activitylog rest client

Description: "Kotlin provides a concise way to check invariants as well
as pre- and post-conditions. Prefer them instead of manually throwing an
IllegalStateException."

For more info see: https://detekt.dev/docs/rules/style/#usecheckorerror

Author: ParaskP7

config/detekt/baseline.xml

@@ -131,7 +131,6 @@
     <ID>TooGenericExceptionCaught:WPV2MediaRestClient.kt$WPV2MediaRestClient.&lt;no name provided>$e: NullPointerException</ID>
     <ID>TooGenericExceptionThrown:ScanStore.kt$ScanStore$throw RuntimeException(msg)</ID>
     <ID>TooGenericExceptionThrown:WPAPIEncodedBodyRequest.kt$WPAPIEncodedBodyRequest$throw RuntimeException("Encoding not supported: $paramsEncoding", uee)</ID>
-    <ID>UseCheckOrError:ActivityLogRestClient.kt$ActivityLogRestClient$throw IllegalStateException("ActivityTypes parsing failed - one or more items were ignored.")</ID>
     <ID>UtilityClassWithPublicConstructor:EncryptionUtils.kt$EncryptionUtils</ID>
     <ID>UtilityClassWithPublicConstructor:WhatsNewAppVersionUtils.kt$WhatsNewAppVersionUtils</ID>
     <ID>VariableNaming:AuthOptionsResponse.kt$AuthOptionsResponse$var email_verified: Boolean? = null</ID>

fluxc/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/activity/ActivityLogRestClient.kt

@@ -418,8 +418,8 @@ class ActivityLogRestClient @Inject constructor(
                 ?.map { ActivityTypeModel(requireNotNull(it.key), requireNotNull(it.name), it.count ?: 0) }
                 ?: listOf()
 
-        if (BuildConfig.DEBUG && (response.groups?.activityTypes?.size ?: 0) != activityTypes.size) {
-            throw IllegalStateException("ActivityTypes parsing failed - one or more items were ignored.")
+        check(!BuildConfig.DEBUG || (response.groups?.activityTypes?.size ?: 0) == activityTypes.size) {
+            "ActivityTypes parsing failed - one or more items were ignored."
         }
 
         return FetchedActivityTypesResultPayload(