Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed collapsing toolbar from stats fragment #21611

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

nbradbury
Copy link
Contributor

This PR fixes a bug introduced by #21606 which causes the stats toolbar to overlap the status bar after scrolling.

After looking into this, I decided the best fix was to simply disable the collapsing toolbar. None of the other "My Site" screens (posts, pages, Media, etc.) collapse the toolbar, so changing Stats to behave the same made sense.

To test, open stats and ensure the scrolling works as expected and doesn't cause the toolbar to overlap the status bar.

BEFORE

stats.mp4

AFTER

stats-fix.mp4

@nbradbury nbradbury marked this pull request as ready for review January 24, 2025 20:40
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 24, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.7. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@nbradbury nbradbury added this to the 25.7 milestone Jan 24, 2025
@nbradbury nbradbury requested a review from jkmassel January 24, 2025 20:52
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21611-2130f24
Commit2130f24
Direct Downloadwordpress-prototype-build-pr21611-2130f24.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21611-2130f24
Commit2130f24
Direct Downloadjetpack-prototype-build-pr21611-2130f24.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury merged commit 650d069 into trunk Jan 24, 2025
26 checks passed
@nbradbury nbradbury deleted the issue/android15-stats-overlap branch January 24, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants