Merge release/24.2 to trigger strings.xml update in GlotPress
#20177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation only ever expects to receive a single category but to keep most of the old code we are still using a List of categories for the sub filter logic. That is not needed on the roo SubfilterBottomSheetFragment though and the presence of the list was causing a crash since the Parcelable implementation of the SubfilterCategory was not working as expected. Removing the list from that Fragment and using a single category lets us remove the `Parcelable` requirement from the SubfilterCategory enum since we can now deal with a simple Serializable class, therefore fixing the crash.
… the tag in the list when unsubscribed, and only change the follow button status
…ash-subfilter-sheet [Reader][Crash] Fix Subfilter sheet crash when restoring instance
… prevent upload notification crash
…llow-tags-logic-manage-screen [Reader] Update follow tags logic in "Manage Tags & Blogs" screen
…oregroundServiceNotificationException Create the transient channel used for upload notification when notifications are disabled
…ression Fix sharing image regression and add support for heic and heif files
|
Found 1 violations: The PR caused the following dependency changes:-\--- org.wordpress:utils:{strictly 3.12.0} -> 3.12.0
+\--- org.wordpress:utils:{strictly 3.13.0} -> 3.13.0
Please review and act accordingly
|
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20177-84f2668 | |
| Commit | 84f2668 | |
| Direct Download | jetpack-prototype-build-pr20177-84f2668.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20177-84f2668 | |
| Commit | 84f2668 | |
| Direct Download | wordpress-prototype-build-pr20177-84f2668.apk |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #20177 +/- ##
==========================================
- Coverage 40.21% 40.20% -0.01%
==========================================
Files 1469 1469
Lines 67573 67584 +11
Branches 11191 11196 +5
==========================================
- Hits 27175 27174 -1
- Misses 37906 37918 +12
Partials 2492 2492 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20138 added a new string which we need to upload to GlotPress for localization. This requires:
bundle exec fastlane update_frozen_strings_for_translationtrunkso that our bot notices the strings change and uploads to GlotPress.84f2668 is step 1, merging this PR will be step 2.
There are other changes in the release branch that will land on
trunk, it would be appropriate to ship a new beta just for consistency. I'll see if I can get to it later.