-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prompts] Build dailyprompt-id tag in code based on the Prompt ID #19971
Conversation
Keep using the answeredLink URL for the "View all responses" search.
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #19971 +/- ##
=======================================
Coverage 40.45% 40.45%
=======================================
Files 1440 1440
Lines 66513 66516 +3
Branches 10957 10959 +2
=======================================
+ Hits 26905 26908 +3
Misses 37121 37121
Partials 2487 2487 ☔ View full report in Codecov by Sentry. |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @thomashorta
It's working as expected and code LGTM
Fixes #19970
Build the
dailyprompt-id
tag in code, using the Prompt ID, but keep using the answeredLink URL for the "View all responses" search.To Test:
Make sure to have a site that supports prompts.
My Site
dashboardAnswer
in the Prompts card or got to the Prompts card menu -> "View more prompts" -> Tap on any promptdailyprompt-<id>
tag is present in theTags
sectionMy Site
View all responses
in the Prompt cardRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: