Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prompts] Build dailyprompt-id tag in code based on the Prompt ID #19971

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

thomashorta
Copy link
Contributor

@thomashorta thomashorta commented Jan 17, 2024

Fixes #19970

Build the dailyprompt-id tag in code, using the Prompt ID, but keep using the answeredLink URL for the "View all responses" search.


To Test:

Make sure to have a site that supports prompts.

  1. Install and log into Jetpack
  2. Go to My Site dashboard
  3. Tap Answer in the Prompts card or got to the Prompts card menu -> "View more prompts" -> Tap on any prompt
  4. On the Editor, hit publish
  5. Verify the dailyprompt-<id> tag is present in the Tags section
  6. Go back to My Site
  7. Tap View all responses in the Prompt card
  8. Verify it still uses the Bloganuary tag (during January)

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Updated unit tests

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Keep using the answeredLink URL for the "View all responses" search.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 17, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19971-a339105
Commita339105
Direct Downloadwordpress-prototype-build-pr19971-a339105.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 17, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19971-a339105
Commita339105
Direct Downloadjetpack-prototype-build-pr19971-a339105.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (916c1cc) 40.45% compared to head (a339105) 40.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #19971   +/-   ##
=======================================
  Coverage   40.45%   40.45%           
=======================================
  Files        1440     1440           
  Lines       66513    66516    +3     
  Branches    10957    10959    +2     
=======================================
+ Hits        26905    26908    +3     
  Misses      37121    37121           
  Partials     2487     2487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.1. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @thomashorta
It's working as expected and code LGTM

@thomashorta thomashorta merged commit f561faa into trunk Jan 18, 2024
20 checks passed
@thomashorta thomashorta deleted the issue/19970-prompts-id-tag branch January 18, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prompts][Bug] The dailyprompt-<id> tag is not being added to Prompt responses during Bloganuary
4 participants