-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans in site creation: Plan selection screen #19304
Conversation
Add Plans step in the flow
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
@ravishanker could you mention the steps to make in the code so I could test with a current Calypso build? Or maybe you have some feedback about the Calypso build to determine if we're good to merge it or if something is still missing? |
Add paid_domain_name and redirect_to params
Generated by 🚫 dangerJS |
Probably, better to test it after merging the Calypso PR. It needs to login on Calypso, and doesn't seem to work with Calypso.live url at the moment. |
Update to the new Calypso url
Add jetpack-app path
pass in plan productId
handle plan selection
update PlanId and PlanSlug
check for plan and product id before cart creation
handle free plan with free domain selection after first selecting paid domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on adding plans and connecting all these steps. 👏🏻
🟡 Creating a free site and a free domain doesn't work as expected. It creates a site with a domain that was not selected.
🟢 I successfully purchased a domain and a plan with a fake purchase.
🟢 No network error screens in site setup and plan section displayed.
🟢 The retry button on the network error screens in the site setup and plan section worked.
🟢 Tapping the back button in various steps in the flow worked as expected.
I've addressed the 🟡 issue in another PR. Also, I haven't included my minor comments here; instead, I've added them to that PR: #19377
Fixes #19284
To test:
Launch
JP appGo
to Me-> Debug settingsSwitch
toRemote Feature
tab, findplans_in_site_creation
and enable itSwitch
to My Site tabTap
the down arrow to the right of the site name on the My Site screenTap
the + icon at the top right on the Site picker screenSelect
⊕ Create WordPress.com site on the modal dialogTap
Skip at top right on the first step (topic screen)Tap
Skip at top right on the next step (theme screen)Enter
a search query (whatever you want here)Verify
that result domains are as shown in the screenshot aboveSelect
a domainVerify
Plans screen opens with Personal, Premium, Business, and Ecommerce plansSelect
a planVerify
it return to site setup screenVerify
it opens checkout, after site setup when an annual paid plan is chosenVerify
it doesn't open checkout if a free domain with free plan is chosen, and site setup is completedVerify
it doesn't allow a annual plan to be selected with a free domainVerify
, select a paid domain on the previous step, then choose to continue with a free domain, free planCheckout
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested various flows
What automated tests I added (or what prevented me from doing so)
Existing unit tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.