Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans in site creation: Plan selection screen #19304

Merged
merged 27 commits into from
Oct 15, 2023

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Oct 5, 2023

Fixes #19284

Domains Plans (to be updated)
Screenshot_20230930_121051 Screenshot_20231015_083133

To test:

Note
Waiting for Automattic/wp-calypso#82135

  • Launch JP app
  • Go to Me-> Debug settings
  • Switch to Remote Feature tab, find plans_in_site_creation and enable it
  • Switch to My Site tab
  • Tap the down arrow to the right of the site name on the My Site screen
  • Tap the + icon at the top right on the Site picker screen
  • SelectCreate WordPress.com site on the modal dialog
  • Tap Skip at top right on the first step (topic screen)
  • Tap Skip at top right on the next step (theme screen)
  • Enter a search query (whatever you want here)
  • Verify that result domains are as shown in the screenshot above
  • Select a domain
  • Verify Plans screen opens with Personal, Premium, Business, and Ecommerce plans
  • Select a plan
  • Verify it return to site setup screen
  • Verify it opens checkout, after site setup when an annual paid plan is chosen
  • Verify it doesn't open checkout if a free domain with free plan is chosen, and site setup is completed
  • Verify it doesn't allow a annual plan to be selected with a free domain
  • Also, Verify, select a paid domain on the previous step, then choose to continue with a free domain, free plan

Checkout

  • Setup sandbox cookie to test checkout (see instructions on Test Plan)
  • Complete checkout with a paid domain, and paid annual plan

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested various flows

  3. What automated tests I added (or what prevented me from doing so)
    Existing unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 5, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19304-05d9682
Commit05d9682
Direct Downloadjetpack-prototype-build-pr19304-05d9682.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 5, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19304-05d9682
Commit05d9682
Direct Downloadwordpress-prototype-build-pr19304-05d9682.apk
Note: Google Login is not supported on these builds.

@staskus
Copy link
Contributor

staskus commented Oct 5, 2023

@ravishanker could you mention the steps to make in the code so I could test with a current Calypso build? Or maybe you have some feedback about the Calypso build to determine if we're good to merge it or if something is still missing?

Add paid_domain_name and redirect_to params
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 6, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@ravishanker
Copy link
Contributor Author

@ravishanker could you mention the steps to make in the code so I could test with a current Calypso build? Or maybe you have some feedback about the Calypso build to determine if we're good to merge it or if something is still missing?

Probably, better to test it after merging the Calypso PR. It needs to login on Calypso, and doesn't seem to work with Calypso.live url at the moment.

@ravishanker ravishanker marked this pull request as ready for review October 13, 2023 04:19
@ravishanker ravishanker requested a review from irfano October 14, 2023 11:25
handle free plan with free domain selection after first selecting paid domain
@irfano irfano mentioned this pull request Oct 15, 2023
12 tasks
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on adding plans and connecting all these steps. 👏🏻
🟡 Creating a free site and a free domain doesn't work as expected. It creates a site with a domain that was not selected.
🟢 I successfully purchased a domain and a plan with a fake purchase.
🟢 No network error screens in site setup and plan section displayed.
🟢 The retry button on the network error screens in the site setup and plan section worked.
🟢 Tapping the back button in various steps in the flow worked as expected.

I've addressed the 🟡 issue in another PR. Also, I haven't included my minor comments here; instead, I've added them to that PR: #19377

@irfano irfano merged commit c54c4f7 into trunk Oct 15, 2023
2 checks passed
@irfano irfano deleted the Plans-in-site-creation-Plan-Selection-Screen branch October 15, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans in Site Creation: Integrate Plan selection into Site Creation flow
4 participants