Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some login dialogs are not styled correctly in Dark Mode #11650

Open
khaykov opened this issue Apr 13, 2020 · 1 comment
Open

Some login dialogs are not styled correctly in Dark Mode #11650

khaykov opened this issue Apr 13, 2020 · 1 comment

Comments

@khaykov
Copy link
Member

khaykov commented Apr 13, 2020

“Continue with” screen on the email sign-in flow and “Choose an account” screen in the Google sign-in flow are not styled correctly in Dark Mode.

We need to investigate how much control we have over them and change their style to match Dark Theme if possible.

@renanferrari
Copy link
Member

renanferrari commented Jun 4, 2020

After some investigation, I unfortunately have not found a way of styling those dialogs with dark mode. Here's what I tried:

  • Updating the Google Sign-In library. My assumption here was that this would be automatically handled by newer versions of the library, but it wasn't the case.
  • Finding a way to customize the theme and styles used by the library. I thought maybe the theme used by the library was something we could override or maybe there would be some styling options hidden somewhere, but none of those were true.
  • Figuring out if it was possible to retrieve the information displayed by the dialog (a list of Google accounts, for example) so we could display it in our own dialog instead, which was not possible as well.

After some benchmarking I realized other apps that use this library are facing the exact same issue, so at least it's not something our users would only see in our app. I think there's nothing we can do at the moment, unless waiting for a library update that would introduce an official way of handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants