Merge pull request #3501 from wordpress-mobile/issue/3487-correctly-track-user-blogs-num

[Analytics] - Tracking the number of blogs

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/ui/accounts/SignInFragment.java

@@ -391,10 +391,10 @@ private void setPrimaryBlog(JSONObject jsonObject) {
     }
 
     private void trackAnalyticsSignIn() {
+        AnalyticsUtils.refreshMetadata();
         Map<String, Boolean> properties = new HashMap<String, Boolean>();
         properties.put("dotcom_user", isWPComLogin());
         AnalyticsTracker.track(AnalyticsTracker.Stat.SIGNED_IN, properties);
-        AnalyticsUtils.refreshMetadata();
         if (!isWPComLogin()) {
             AnalyticsTracker.track(AnalyticsTracker.Stat.ADDED_SELF_HOSTED_SITE);
         }

WordPress/src/main/java/org/wordpress/android/util/AnalyticsUtils.java

@@ -34,7 +34,7 @@ public static void refreshMetadata(String username, String email) {
         boolean isUserConnected = AccountHelper.isSignedIn();
         boolean isWordPressComUser = AccountHelper.isSignedInWordPressDotCom();
         boolean isJetpackUser = AccountHelper.isJetPackUser();
-        int numBlogs = WordPress.wpDB.getVisibleBlogs().size();
+        int numBlogs = WordPress.wpDB.getNumBlogs();
         int versionCode = PackageUtils.getVersionCode(WordPress.getContext());
         AnalyticsTracker.refreshMetadata(isUserConnected, isWordPressComUser, isJetpackUser, sessionCount, numBlogs,
                 versionCode, username, email);
@@ -49,7 +49,7 @@ public static void refreshMetadata() {
         boolean isUserConnected = AccountHelper.isSignedIn();
         boolean isWordPressComUser = AccountHelper.isSignedInWordPressDotCom();
         boolean isJetpackUser = AccountHelper.isJetPackUser();
-        int numBlogs = WordPress.wpDB.getVisibleBlogs().size();
+        int numBlogs = WordPress.wpDB.getNumBlogs();
         int versionCode = PackageUtils.getVersionCode(WordPress.getContext());
         String username = AccountHelper.getDefaultAccount().getUserName();
         String email = AccountHelper.getDefaultAccount().getEmail();

libs/analytics/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java

@@ -457,6 +457,15 @@ public void refreshMetadata(boolean isUserConnected, boolean isWordPressComUser,
             return;
         }
 
+        try {
+            JSONObject properties = new JSONObject();
+            properties.put(JETPACK_USER, isJetpackUser);
+            properties.put(NUMBER_OF_BLOGS, numBlogs);
+            mNosaraClient.registerUserProperties(properties);
+        } catch (JSONException e) {
+            AppLog.e(AppLog.T.UTILS, e);
+        }
+
         if (isUserConnected && isWordPressComUser) {
             setWordPressComUserName(username);
             // Re-unify the user
@@ -472,14 +481,7 @@ public void refreshMetadata(boolean isUserConnected, boolean isWordPressComUser,
             }
         }
 
-        try {
-            JSONObject properties = new JSONObject();
-            properties.put(JETPACK_USER, isJetpackUser);
-            properties.put(NUMBER_OF_BLOGS, numBlogs);
-            mNosaraClient.registerUserProperties(properties);
-        } catch (JSONException e) {
-            AppLog.e(AppLog.T.UTILS, e);
-        }
+
     }