Skip to content

Commit f71193b

Browse files
committed
Merge branch 'hotfix/4.3.2' into develop
Conflicts: WordPress/build.gradle libs/analytics/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java libs/analytics/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java
2 parents 66fa906 + 88020dc commit f71193b

File tree

3 files changed

+21
-4
lines changed

3 files changed

+21
-4
lines changed

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ public enum Stat {
6969
EDITOR_TAPPED_MORE,
7070
EDITOR_TAPPED_STRIKETHROUGH,
7171
EDITOR_TAPPED_UNDERLINE,
72+
ME_ACCESSED,
73+
MY_SITE_ACCESSED,
7274
NOTIFICATIONS_ACCESSED,
7375
NOTIFICATIONS_OPENED_NOTIFICATION_DETAILS,
7476
NOTIFICATION_REPLIED_TO,
@@ -84,7 +86,7 @@ public enum Stat {
8486
OPENED_VIEW_SITE,
8587
OPENED_VIEW_ADMIN,
8688
OPENED_MEDIA_LIBRARY,
87-
OPENED_SETTINGS,
89+
OPENED_BLOG_SETTINGS,
8890
CREATED_ACCOUNT,
8991
ACCOUNT_LOGOUT,
9092
SHARED_ITEM,

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import java.util.EnumMap;
1919
import java.util.Iterator;
20-
import java.util.Locale;
2120
import java.util.Map;
2221

2322
public class AnalyticsTrackerMixpanel implements AnalyticsTracker.Tracker {
@@ -525,7 +524,7 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
525524
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
526525
mixpanelInstructionsForEventName("Site Menu - Opened Media Library");
527526
break;
528-
case OPENED_SETTINGS:
527+
case OPENED_BLOG_SETTINGS:
529528
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
530529
mixpanelInstructionsForEventName("Site Menu - Opened Settings");
531530
break;
@@ -686,6 +685,16 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
686685
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
687686
mixpanelInstructionsForEventName("Notification Settings - Updated");
688687
break;
688+
case ME_ACCESSED:
689+
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
690+
mixpanelInstructionsForEventName("Me Tab - Accessed");
691+
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_accessed_me_tab");
692+
break;
693+
case MY_SITE_ACCESSED:
694+
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
695+
mixpanelInstructionsForEventName("My Site - Accessed");
696+
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_accessed_my_site");
697+
break;
689698
default:
690699
instructions = null;
691700
break;

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
240240
eventName = "site_menu_opened";
241241
predefinedEventProperties.put("menu_item", "media_library");
242242
break;
243-
case OPENED_SETTINGS:
243+
case OPENED_BLOG_SETTINGS:
244244
eventName = "site_menu_opened";
245245
predefinedEventProperties.put("menu_item", "settings");
246246
break;
@@ -347,6 +347,12 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
347347
case NOTIFICATION_SETTINGS_UPDATED:
348348
eventName = "notification_settings_updated";
349349
break;
350+
case ME_ACCESSED:
351+
eventName = "me_tab_accessed";
352+
break;
353+
case MY_SITE_ACCESSED:
354+
eventName = "my_site_tab_accessed";
355+
break;
350356
default:
351357
eventName = null;
352358
break;

0 commit comments

Comments
 (0)