Throw an IllegalArgumentException exception if a null context is passed

Author: daniloercoli

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java

@@ -4,12 +4,9 @@
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
 
-import org.wordpress.android.util.AppLog;
-
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
-import java.util.UUID;
 
 public final class AnalyticsTracker {
     private static boolean mHasUserOptedOut;

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java

@@ -9,7 +9,6 @@
 import android.os.Build;
 import android.preference.PreferenceManager;
 
-import com.automattic.android.tracks.TracksClient;
 import com.mixpanel.android.mpmetrics.MixpanelAPI;
 
 import org.json.JSONException;
@@ -34,7 +33,7 @@ public class AnalyticsTrackerMixpanel extends Tracker {
     private static final String APP_LOCALE = "app_locale";
     private static final String MIXPANEL_ANON_ID = "mixpanel_user_anon_id";
 
-    public AnalyticsTrackerMixpanel(Context context, String token) {
+    public AnalyticsTrackerMixpanel(Context context, String token) throws IllegalArgumentException {
         super(context);
         mAggregatedProperties = new EnumMap<AnalyticsTracker.Stat, JSONObject>(AnalyticsTracker.Stat.class);
         mMixpanel = MixpanelAPI.getInstance(context, token);

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java

@@ -1,8 +1,6 @@
 package org.wordpress.android.analytics;
 
 import android.content.Context;
-import android.content.SharedPreferences;
-import android.preference.PreferenceManager;
 
 import com.automattic.android.tracks.TracksClient;
 
@@ -12,7 +10,6 @@
 
 import java.util.HashMap;
 import java.util.Map;
-import java.util.UUID;
 
 public class AnalyticsTrackerNosara extends Tracker {
 
@@ -24,12 +21,8 @@ public class AnalyticsTrackerNosara extends Tracker {
 
     private TracksClient mNosaraClient;
 
-    public AnalyticsTrackerNosara(Context context) {
+    public AnalyticsTrackerNosara(Context context) throws IllegalArgumentException {
         super(context);
-        if (null == context) {
-            mNosaraClient = null;
-            return;
-        }
         mNosaraClient = TracksClient.getClient(context);
     }
 

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/Tracker.java

@@ -23,9 +23,9 @@ abstract void refreshMetadata(boolean isUserConnected,boolean isWordPressComUser
     private String mWpcomUserName = null;
     Context mContext;
 
-    public Tracker(Context context) {
+    public Tracker(Context context) throws IllegalArgumentException {
         if (null == context) {
-            return;
+            throw new IllegalArgumentException("Tracker requires a not-null context");
         }
         mContext = context;
     }