Skip to content

Commit e3a45d5

Browse files
authored
Merge pull request #18364 from wordpress-mobile/deps/main-batch-androidx-compose-kotlin
[Dependency Updates] Main Batch - AndroidX Compose/Kotlin (plus Core)
2 parents d59519a + 63d1e6c commit e3a45d5

File tree

113 files changed

+506
-548
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

113 files changed

+506
-548
lines changed

WordPress/build.gradle

Lines changed: 38 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -373,10 +373,6 @@ dependencies {
373373
}
374374
implementation "org.wordpress:persistentedittext:$wordPressPersistentEditTextVersion"
375375

376-
// To enable Android Studio specific features for Jetpack Compose.
377-
debugImplementation "androidx.compose.ui:ui-test-manifest:$androidxComposeVersion"
378-
debugImplementation "androidx.compose.ui:ui-tooling:$androidxComposeVersion"
379-
implementation "androidx.compose.ui:ui-tooling-preview:$androidxComposeVersion"
380376
// To enable Stetho, a debug bridge that enables the Chrome Developer Tools for debug purposes.
381377
debugImplementation "com.facebook.stetho:stetho:$stethoVersion"
382378
debugImplementation "com.facebook.stetho:stetho-okhttp3:$stethoVersion"
@@ -405,7 +401,6 @@ dependencies {
405401
implementation "androidx.work:work-runtime:$androidxWorkManagerVersion"
406402
implementation "androidx.work:work-runtime-ktx:$androidxWorkManagerVersion"
407403
implementation "androidx.constraintlayout:constraintlayout:$androidxConstraintlayoutVersion"
408-
implementation "androidx.constraintlayout:constraintlayout-compose:$androidxConstraintlayoutComposeVersion"
409404
implementation "androidx.lifecycle:lifecycle-viewmodel:$androidxLifecycleVersion"
410405
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:$androidxLifecycleVersion"
411406
implementation "androidx.lifecycle:lifecycle-livedata-core:$androidxLifecycleVersion"
@@ -426,7 +421,6 @@ dependencies {
426421
implementation "com.squareup.retrofit2:retrofit:$squareupRetrofitVersion"
427422
implementation "org.apache.commons:commons-text:$apacheCommonsTextVersion"
428423
implementation "com.airbnb.android:lottie:$lottieVersion"
429-
implementation "com.airbnb.android:lottie-compose:$lottieVersion"
430424
implementation "com.facebook.shimmer:shimmer:$facebookShimmerVersion"
431425
implementation ("com.github.yalantis:ucrop:$uCropVersion") {
432426
exclude group: 'androidx.core', module: 'core'
@@ -436,17 +430,6 @@ dependencies {
436430
implementation "com.github.bumptech.glide:glide:$glideVersion"
437431
kapt "com.github.bumptech.glide:compiler:$glideVersion"
438432
implementation "com.github.bumptech.glide:volley-integration:$glideVolleyVersion"
439-
implementation "androidx.compose.runtime:runtime:$androidxComposeVersion"
440-
implementation "androidx.compose.runtime:runtime-livedata:$androidxComposeVersion"
441-
implementation "androidx.compose.foundation:foundation:$androidxComposeVersion"
442-
implementation "androidx.compose.foundation:foundation-layout:$androidxComposeVersion"
443-
implementation "androidx.compose.ui:ui:$androidxComposeVersion"
444-
implementation "androidx.compose.ui:ui-graphics:$androidxComposeVersion"
445-
implementation "androidx.compose.ui:ui-text:$androidxComposeVersion"
446-
implementation "androidx.compose.ui:ui-unit:$androidxComposeVersion"
447-
implementation "androidx.compose.material:material:$androidxComposeVersion"
448-
implementation "androidx.lifecycle:lifecycle-viewmodel-compose:$androidxComposeLifecycleVersion"
449-
implementation "io.coil-kt:coil-compose:$coilComposeVersion"
450433
implementation "com.github.indexos.media-for-mobile:domain:$indexosMediaForMobileVersion"
451434
implementation "com.github.indexos.media-for-mobile:android:$indexosMediaForMobileVersion"
452435
implementation "com.zendesk:support:$zendeskVersion"
@@ -484,14 +467,24 @@ dependencies {
484467
androidTestImplementation "com.squareup.okhttp3:mockwebserver:$squareupMockWebServerVersion"
485468
androidTestImplementation "androidx.test.uiautomator:uiautomator:$androidxTestUiAutomatorVersion"
486469
androidTestImplementation "androidx.test.espresso:espresso-core:$androidxTestEspressoVersion", {
470+
version {
471+
strictly androidxTestEspressoVersion
472+
}
487473
exclude group: 'com.android.support', module: 'support-annotations'
488474
}
489475
androidTestImplementation("androidx.test.espresso:espresso-contrib:$androidxTestEspressoVersion") {
476+
version {
477+
strictly androidxTestEspressoVersion
478+
}
490479
exclude group: 'com.android.support', module: 'appcompat'
491480
exclude group: 'com.android.support', module: 'support-v4'
492481
exclude module: 'recyclerview-v7'
493482
}
494-
androidTestImplementation "androidx.test.espresso:espresso-accessibility:$androidxTestEspressoVersion"
483+
androidTestImplementation("androidx.test.espresso:espresso-accessibility:$androidxTestEspressoVersion") {
484+
version {
485+
strictly androidxTestEspressoVersion
486+
}
487+
}
495488
androidTestImplementation("com.github.tomakehurst:wiremock:$wiremockVersion") {
496489
exclude group: 'org.apache.httpcomponents', module: 'httpclient'
497490
exclude group: 'org.apache.commons', module: 'commons-lang3'
@@ -509,10 +502,36 @@ dependencies {
509502
androidTestImplementation "androidx.work:work-testing:$androidxWorkManagerVersion"
510503
androidTestImplementation "com.google.dagger:hilt-android-testing:$gradle.ext.daggerVersion"
511504
kaptAndroidTest "com.google.dagger:hilt-android-compiler:$gradle.ext.daggerVersion"
512-
androidTestImplementation "androidx.compose.ui:ui-test-junit4:$androidxComposeVersion"
513505
// Enables Java 8+ API desugaring support
514506
coreLibraryDesugaring "com.android.tools:desugar_jdk_libs:$androidDesugarVersion"
515507
lintChecks "org.wordpress:lint:$wordPressLintVersion"
508+
509+
// Jetpack Compose
510+
def composeBom = platform("androidx.compose:compose-bom:$androidxComposeBomVersion")
511+
implementation(composeBom)
512+
androidTestImplementation(composeBom)
513+
// - Jetpack Compose - Android Studio
514+
debugImplementation "androidx.compose.ui:ui-test-manifest"
515+
debugImplementation "androidx.compose.ui:ui-tooling"
516+
// - Jetpack Compose - Main
517+
implementation "androidx.compose.runtime:runtime"
518+
implementation "androidx.compose.runtime:runtime-livedata"
519+
implementation "androidx.compose.foundation:foundation"
520+
implementation "androidx.compose.foundation:foundation-layout"
521+
implementation "androidx.compose.ui:ui"
522+
implementation "androidx.compose.ui:ui-graphics"
523+
implementation "androidx.compose.ui:ui-text"
524+
implementation "androidx.compose.ui:ui-unit"
525+
implementation "androidx.compose.ui:ui-tooling-preview"
526+
implementation "androidx.compose.material:material"
527+
// - Jetpack Compose - AndroidX
528+
implementation "androidx.lifecycle:lifecycle-viewmodel-compose:$androidxLifecycleVersion"
529+
implementation "androidx.constraintlayout:constraintlayout-compose:$androidxConstraintlayoutComposeVersion"
530+
// - Jetpack Compose - Other
531+
implementation "io.coil-kt:coil-compose:$coilComposeVersion"
532+
implementation "com.airbnb.android:lottie-compose:$lottieVersion"
533+
// - Jetpack Compose - UI Tests
534+
androidTestImplementation "androidx.compose.ui:ui-test-junit4"
516535
}
517536

518537
configurations.all {

WordPress/src/androidTest/java/org/wordpress/android/UserAgentTest.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,17 @@ public class UserAgentTest {
2525
public InitializationRule initRule = new InitializationRule();
2626

2727
@Test
28-
public void testGetDefaultUserAgent() {
29-
String defaultUserAgent = WordPress.getDefaultUserAgent();
30-
assertNotNull("Default User-Agent must be set", defaultUserAgent);
31-
assertTrue("Default User-Agent must not be an empty string", defaultUserAgent.length() > 0);
32-
assertFalse("Default User-Agent must not contain app name", defaultUserAgent.contains(USER_AGENT_APPNAME));
33-
}
34-
35-
@Test
36-
public void testGetUserAgent() {
28+
public void testGetUserAgentAndGetDefaultUserAgent() {
3729
String userAgent = WordPress.getUserAgent();
3830
assertNotNull("User-Agent must be set", userAgent);
3931
assertTrue("User-Agent must not be an empty string", userAgent.length() > 0);
4032
assertTrue("User-Agent must contain app name substring", userAgent.contains(USER_AGENT_APPNAME));
4133

4234
String defaultUserAgent = WordPress.getDefaultUserAgent();
35+
assertNotNull("Default User-Agent must be set", defaultUserAgent);
36+
assertTrue("Default User-Agent must not be an empty string", defaultUserAgent.length() > 0);
37+
assertFalse("Default User-Agent must not contain app name", defaultUserAgent.contains(USER_AGENT_APPNAME));
38+
4339
assertTrue("User-Agent must be derived from default User-Agent", userAgent.contains(defaultUserAgent));
4440
}
4541
}

WordPress/src/androidTest/java/org/wordpress/android/e2e/LoginTests.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.wordpress.android.e2e
22

33
import dagger.hilt.android.testing.HiltAndroidTest
4-
import org.junit.After
54
import org.junit.Before
65
import org.junit.Test
76
import org.wordpress.android.BuildConfig

0 commit comments

Comments
 (0)