Squashed 'libs/editor/' changes from 260a0d5..7dcc1a9

7dcc1a9 Merge pull request #435 from wordpress-mobile/issue/432-evaluateJavaScript-not-supported
3b5fd66 Added debug logging when reverting to compatibility EditorWebView for custom ROMs
be1722d Set WebView LayoutParams when reverting to compatibility WebView for custom ROM fix
a6d3101 Check for custom ROMs using a 4.3 WebView in a 4.4 Android build, and revert to compatibility WebView for those devices

git-subtree-dir: libs/editor
git-subtree-split: 7dcc1a99138131dcafd020948f2100ab6c3c7b58

Author: maxme

WordPressEditor/src/main/java/org/wordpress/android/editor/EditorFragment.java

@@ -26,6 +26,7 @@
 import android.view.inputmethod.InputMethodManager;
 import android.webkit.URLUtil;
 import android.webkit.WebView;
+import android.widget.RelativeLayout.LayoutParams;
 import android.widget.ToggleButton;
 
 import com.android.volley.toolbox.ImageLoader;
@@ -148,6 +149,16 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
 
         mWebView = (EditorWebViewAbstract) view.findViewById(R.id.webview);
 
+        // Revert to compatibility WebView for custom ROMs using a 4.3 WebView in Android 4.4
+        if (mWebView.shouldSwitchToCompatibilityMode()) {
+            ViewGroup parent = (ViewGroup) mWebView.getParent();
+            int index = parent.indexOfChild(mWebView);
+            parent.removeView(mWebView);
+            mWebView = new EditorWebViewCompatibility(getActivity(), null);
+            mWebView.setLayoutParams(new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));
+            parent.addView(mWebView, index);
+        }
+
         mWebView.setOnTouchListener(this);
         mWebView.setOnImeBackListener(this);
         mWebView.setAuthHeaderRequestListener(this);

WordPressEditor/src/main/java/org/wordpress/android/editor/EditorWebView.java

@@ -5,6 +5,8 @@
 import android.os.Build;
 import android.util.AttributeSet;
 
+import org.wordpress.android.util.AppLog;
+
 public class EditorWebView extends EditorWebViewAbstract {
 
     public EditorWebView(Context context, AttributeSet attrs) {
@@ -13,11 +15,21 @@ public EditorWebView(Context context, AttributeSet attrs) {
 
     @SuppressLint("NewApi")
     public void execJavaScriptFromString(String javaScript) {
-        if (Build.VERSION.SDK_INT >= 19) {
-            this.evaluateJavascript(javaScript, null);
-        } else {
-            this.loadUrl("javascript:" + javaScript);
-        }
+        this.evaluateJavascript(javaScript, null);
     }
 
+    @SuppressLint("NewApi")
+    @Override
+    public boolean shouldSwitchToCompatibilityMode() {
+        if (Build.VERSION.SDK_INT <= 19) {
+            try {
+                this.evaluateJavascript("", null);
+            } catch (NoSuchMethodError | IllegalStateException e) {
+                AppLog.d(AppLog.T.EDITOR,
+                        "Detected 4.4 ROM using classic WebView, reverting to compatibility EditorWebView.");
+                return true;
+            }
+        }
+        return false;
+    }
 }

WordPressEditor/src/main/java/org/wordpress/android/editor/EditorWebViewAbstract.java

@@ -179,6 +179,11 @@ public void setVisibility(int visibility) {
         super.setVisibility(visibility);
     }
 
+
+    public boolean shouldSwitchToCompatibilityMode() {
+        return false;
+    }
+
     public void setDebugModeEnabled(boolean enabled) {
         mDebugModeEnabled = enabled;
     }