Skip to content

Commit 531b986

Browse files
committed
Merge branch 'develop' of github.com:wordpress-mobile/WordPress-Android into feature/modularize-editor
2 parents 2b40042 + ee83fe3 commit 531b986

File tree

2 files changed

+37
-4
lines changed

2 files changed

+37
-4
lines changed

WordPressUtils/src/main/java/org/wordpress/android/util/helpers/SwipeToRefreshHelper.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,26 @@
33
import android.app.Activity;
44
import android.content.Context;
55
import android.content.res.TypedArray;
6-
import android.support.v4.widget.SwipeRefreshLayout;
76
import android.support.v4.widget.SwipeRefreshLayout.OnRefreshListener;
87
import android.util.TypedValue;
98

109
import org.wordpress.android.util.R;
10+
import org.wordpress.android.util.widgets.CustomSwipeRefreshLayout;
1111

1212
public class SwipeToRefreshHelper implements OnRefreshListener {
13-
private SwipeRefreshLayout mSwipeRefreshLayout;
13+
private CustomSwipeRefreshLayout mSwipeRefreshLayout;
1414
private RefreshListener mRefreshListener;
1515
private boolean mRefreshing;
1616

1717
public interface RefreshListener {
1818
public void onRefreshStarted();
1919
}
2020

21-
public SwipeToRefreshHelper(Activity activity, SwipeRefreshLayout swipeRefreshLayout, RefreshListener listener) {
21+
public SwipeToRefreshHelper(Activity activity, CustomSwipeRefreshLayout swipeRefreshLayout, RefreshListener listener) {
2222
init(activity, swipeRefreshLayout, listener);
2323
}
2424

25-
public void init(Activity activity, SwipeRefreshLayout swipeRefreshLayout, RefreshListener listener) {
25+
public void init(Activity activity, CustomSwipeRefreshLayout swipeRefreshLayout, RefreshListener listener) {
2626
mRefreshListener = listener;
2727
mSwipeRefreshLayout = swipeRefreshLayout;
2828
mSwipeRefreshLayout.setOnRefreshListener(this);
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
package org.wordpress.android.util.widgets;
2+
3+
import android.content.Context;
4+
import android.support.v4.widget.SwipeRefreshLayout;
5+
import android.util.AttributeSet;
6+
import android.view.MotionEvent;
7+
8+
import org.wordpress.android.util.AppLog;
9+
import org.wordpress.android.util.AppLog.T;
10+
11+
public class CustomSwipeRefreshLayout extends SwipeRefreshLayout {
12+
public CustomSwipeRefreshLayout(Context context) {
13+
super(context);
14+
}
15+
16+
public CustomSwipeRefreshLayout(Context context, AttributeSet attrs) {
17+
super(context, attrs);
18+
}
19+
20+
@Override
21+
public boolean onTouchEvent(MotionEvent event) {
22+
try{
23+
return super.onTouchEvent(event);
24+
} catch(IllegalArgumentException e) {
25+
// Fix for https://github.com/wordpress-mobile/WordPress-Android/issues/2373
26+
// Catch IllegalArgumentException which can be fired by the underlying SwipeRefreshLayout.onTouchEvent()
27+
// method.
28+
// When android support-v4 fixes it, we'll have to remove that custom layout completely.
29+
AppLog.e(T.UTILS, e);
30+
return true;
31+
}
32+
}
33+
}

0 commit comments

Comments
 (0)