Merge pull request #9098 from wordpress-mobile/fix/uploader-service-crash

PostUploader service: moved initialization of helper classes to onCreate()

Author: aforcier

WordPress/src/main/java/org/wordpress/android/ui/uploads/UploadService.java

@@ -87,6 +87,18 @@ public void onCreate() {
         mDispatcher.register(this);
         sInstance = this;
         // TODO: Recover any posts/media uploads that were interrupted by the service being stopped
+
+        if (mMediaUploadHandler == null) {
+            mMediaUploadHandler = new MediaUploadHandler();
+        }
+
+        if (mPostUploadNotifier == null) {
+            mPostUploadNotifier = new PostUploadNotifier(getApplicationContext(), this);
+        }
+
+        if (mPostUploadHandler == null) {
+            mPostUploadHandler = new PostUploadHandler(mPostUploadNotifier);
+        }
     }
 
     @Override
@@ -128,18 +140,6 @@ public int onStartCommand(Intent intent, int flags, int startId) {
             return START_NOT_STICKY;
         }
 
-        if (mMediaUploadHandler == null) {
-            mMediaUploadHandler = new MediaUploadHandler();
-        }
-
-        if (mPostUploadNotifier == null) {
-            mPostUploadNotifier = new PostUploadNotifier(getApplicationContext(), this);
-        }
-
-        if (mPostUploadHandler == null) {
-            mPostUploadHandler = new PostUploadHandler(mPostUploadNotifier);
-        }
-
         if (intent.hasExtra(KEY_MEDIA_LIST)) {
             unpackMediaIntent(intent);
         }