Squashed 'libs/login/' changes from cfc0675d21..a3a1c83492

Amanda Riu · Amanda Riu · commit 46923a963c48 · 2020-06-10T16:04:01.000-06:00
a3a1c83492 Merge pull request #37 from wordpress-mobile/merge/woocommerce-android/dark-mode 990df9483d Merge pull request #40 from wordpress-mobile/fix/9905_Crash_InflateException_Binary_XML_file_line_NEW dfd3ed8246 Fix password drawable bf3e2f3228 Merge pull request #38 from wordpress-mobile/fix/11307-The-wrong-icon-is-used-when-a-Password-is-visible 1428361e69 Merge pull request #39 from wordpress-mobile/merge/WordPress-Android/11934-take2 b77a144e99 using getViewLifecycleOwner() for observers e2f7c1cdee Replace wrong icon with the right one git-subtree-dir: libs/login git-subtree-split: a3a1c834921064c31840003aaa91e4bf8f4f91fc
diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java
@@ -141,12 +141,12 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
 
         mLoginSiteAddressValidator = new LoginSiteAddressValidator();
 
-        mLoginSiteAddressValidator.getIsValid().observe(this, new Observer<Boolean>() {
+        mLoginSiteAddressValidator.getIsValid().observe(getViewLifecycleOwner(), new Observer<Boolean>() {
             @Override public void onChanged(Boolean enabled) {
                 getPrimaryButton().setEnabled(enabled);
             }
         });
-        mLoginSiteAddressValidator.getErrorMessageResId().observe(this, new Observer<Integer>() {
+        mLoginSiteAddressValidator.getErrorMessageResId().observe(getViewLifecycleOwner(), new Observer<Integer>() {
             @Override public void onChanged(Integer resId) {
                 if (resId != null) {
                     showError(resId);
diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/widgets/WPLoginInputRow.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/widgets/WPLoginInputRow.java
@@ -79,8 +79,8 @@ private void init(Context context, AttributeSet attrs) {
                     mEditText.setHintTextColor(getResources().getColor(android.R.color.transparent));
                 }
                 if (a.hasValue(R.styleable.wpLoginInputRow_passwordToggleEnabled)) {
-                    mTextInputLayout.setPasswordVisibilityToggleEnabled(
-                            a.getBoolean(R.styleable.wpLoginInputRow_passwordToggleEnabled, false));
+                    mTextInputLayout.setEndIconMode(TextInputLayout.END_ICON_PASSWORD_TOGGLE);
+                    mTextInputLayout.setEndIconDrawable(R.drawable.selector_password_visibility);
                 }
 
                 if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
diff --git a/WordPressLoginFlow/src/main/res/drawable-xhdpi/ic_password_visibility.png b/WordPressLoginFlow/src/main/res/drawable-xhdpi/ic_password_visibility.png

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,8 @@ private void init(Context context, AttributeSet attrs) {`
`79`	`79`	`mEditText.setHintTextColor(getResources().getColor(android.R.color.transparent));`
`80`	`80`	`}`
`81`	`81`	`if (a.hasValue(R.styleable.wpLoginInputRow_passwordToggleEnabled)) {`
`82`		`- mTextInputLayout.setPasswordVisibilityToggleEnabled(`
`83`		`- a.getBoolean(R.styleable.wpLoginInputRow_passwordToggleEnabled, false));`
	`82`	`+ mTextInputLayout.setEndIconMode(TextInputLayout.END_ICON_PASSWORD_TOGGLE);`
	`83`	`+ mTextInputLayout.setEndIconDrawable(R.drawable.selector_password_visibility);`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {`