Merge pull request #17197 from wordpress-mobile/analysis/processors-all-warnings-as-errors

[Compile Warnings As Errors] Processors Module - Resolve Warnings & Enable All Warnings as Errors

Author: ParaskP7

build.gradle

@@ -12,6 +12,7 @@ plugins {
 ext {
     wordPressUtilsVersion = '2.7.0'
     wordPressLoginVersion = '0.19.0'
+    aztecVersion = 'v1.6.0'
     gutenbergMobileVersion = 'v1.82.1'
     storiesVersion = '1.4.0'
     aboutAutomatticVersion = '0.0.6'
@@ -44,6 +45,10 @@ ext {
 
     composeVersion = '1.1.1'
 
+    // annotations/processors
+    kotlinPoetVersion = '1.6.0'
+    autoServiceVersion = '1.0'
+
     // testing
     jUnitVersion = '4.13'
     jUnitExtVersion = '1.1.3'

libs/editor/build.gradle

@@ -4,8 +4,6 @@ plugins {
     id "org.jetbrains.kotlin.plugin.parcelize"
 }
 
-ext.aztecVersion = 'v1.6.0'
-
 repositories {
     maven {
         url "https://a8c-libs.s3.amazonaws.com/android"

libs/processors/build.gradle

@@ -3,8 +3,11 @@ plugins {
     id "org.jetbrains.kotlin.kapt"
 }
 
-ext.kotlinPoetVersion = '1.6.0'
-ext.autoServiceVersion = '1.0'
+compileKotlin {
+    kotlinOptions {
+        allWarningsAsErrors = true
+    }
+}
 
 dependencies {
     implementation project(':libs:annotations')

libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigCheckBuilder.kt

@@ -11,6 +11,7 @@ import com.squareup.kotlinpoet.TypeSpec
 import java.util.Locale
 
 class RemoteConfigCheckBuilder(private val remoteFeatures: List<TypeName>) {
+    @Suppress("DEPRECATION")
     fun getContent(): FileSpec {
         val remoteFeaturesWithNames = remoteFeatures.map {
             it.toString()
@@ -49,10 +50,10 @@ class RemoteConfigCheckBuilder(private val remoteFeatures: List<TypeName>) {
     private fun buildCheckFunction(remoteFeatures: List<Pair<String, TypeName>>): CodeBlock {
         val stringBuilder = StringBuilder()
         remoteFeatures.forEach { feature ->
-            stringBuilder.appendln("if (${feature.first}.remoteField == null) {")
+            stringBuilder.appendLine("if (${feature.first}.remoteField == null) {")
             val error = "    throw IllegalArgumentException(\"\"\"${feature.second} needs to define remoteField\"\"\")"
-            stringBuilder.appendln(error)
-            stringBuilder.appendln("}")
+            stringBuilder.appendLine(error)
+            stringBuilder.appendLine("}")
         }
         return CodeBlock.of(stringBuilder.toString().trimIndent())
     }

libs/processors/src/main/java/org/wordpress/android/processor/RemoteConfigProcessor.kt

@@ -24,6 +24,7 @@ import javax.tools.Diagnostic.Kind
         "org.wordpress.android.annotation.FeatureInDevelopment"
 )
 class RemoteConfigProcessor : AbstractProcessor() {
+    @Suppress("DEPRECATION")
     override fun process(p0: MutableSet<out TypeElement>?, roundEnvironment: RoundEnvironment?): Boolean {
         val experiments = roundEnvironment?.getElementsAnnotatedWith(Experiment::class.java)?.map { element ->
             val annotation = element.getAnnotation(Experiment::class.java)