Skip to content

Commit 36e3c7b

Browse files
committed
Merge branch 'develop' of github.com:wordpress-mobile/WordPress-Android into develop
2 parents 229c864 + be29fba commit 36e3c7b

File tree

3 files changed

+10
-28
lines changed

3 files changed

+10
-28
lines changed

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ public enum Stat {
2525
READER_ARTICLE_COMMENTED_ON,
2626
READER_ARTICLE_LIKED,
2727
READER_ARTICLE_OPENED,
28-
READER_ARTICLE_REBLOGGED,
2928
READER_ARTICLE_UNLIKED,
3029
READER_BLOG_BLOCKED,
3130
READER_BLOG_FOLLOWED,
@@ -49,7 +48,6 @@ public enum Stat {
4948
STATS_PERIOD_YEARS_ACCESSED,
5049
STATS_VIEW_ALL_ACCESSED,
5150
STATS_SINGLE_POST_ACCESSED,
52-
STATS_OPENED_WEB_VERSION,
5351
STATS_TAPPED_BAR_CHART,
5452
STATS_SCROLLED_TO_BOTTOM,
5553
STATS_WIDGET_ADDED,

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -299,12 +299,6 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
299299
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_opened_article");
300300
instructions.setCurrentDateForPeopleProperty("last_time_opened_reader_article");
301301
break;
302-
case READER_ARTICLE_REBLOGGED:
303-
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
304-
mixpanelInstructionsForEventName("Reader - Reblogged Article");
305-
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_reblogged_article");
306-
instructions.setCurrentDateForPeopleProperty("last_time_reblogged_article");
307-
break;
308302
case READER_ARTICLE_UNLIKED:
309303
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
310304
mixpanelInstructionsForEventName("Reader - Unliked Article");
@@ -655,12 +649,6 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
655649
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_accessed_single_post_screen_stats");
656650
instructions.setCurrentDateForPeopleProperty("last_time_accessed_single_post_screen_stats");
657651
break;
658-
case STATS_OPENED_WEB_VERSION:
659-
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
660-
mixpanelInstructionsForEventName("Stats - Opened Web Version");
661-
instructions.setSuperPropertyAndPeoplePropertyToIncrement("number_of_times_accessed_web_version_of_stats");
662-
instructions.setCurrentDateForPeopleProperty("last_time_accessed_web_version_of_stats");
663-
break;
664652
case STATS_TAPPED_BAR_CHART:
665653
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
666654
mixpanelInstructionsForEventName("Stats - Tapped Bar Chart");

WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
6969
case READER_ARTICLE_OPENED:
7070
eventName = "reader_article_opened";
7171
break;
72-
case READER_ARTICLE_REBLOGGED:
73-
eventName = "reader_article_reblogged";
74-
break;
7572
case READER_ARTICLE_UNLIKED:
7673
eventName = "reader_article_unliked";
7774
break;
@@ -285,9 +282,6 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
285282
case STATS_SINGLE_POST_ACCESSED:
286283
eventName = "stats_single_post_accessed";
287284
break;
288-
case STATS_OPENED_WEB_VERSION:
289-
eventName = "stats_web_version_accessed";
290-
break;
291285
case STATS_TAPPED_BAR_CHART:
292286
eventName = "stats_bar_chart_tapped";
293287
break;
@@ -460,6 +454,15 @@ public void refreshMetadata(boolean isUserConnected, boolean isWordPressComUser,
460454
return;
461455
}
462456

457+
try {
458+
JSONObject properties = new JSONObject();
459+
properties.put(JETPACK_USER, isJetpackUser);
460+
properties.put(NUMBER_OF_BLOGS, numBlogs);
461+
mNosaraClient.registerUserProperties(properties);
462+
} catch (JSONException e) {
463+
AppLog.e(AppLog.T.UTILS, e);
464+
}
465+
463466
if (isUserConnected && isWordPressComUser) {
464467
setWordPressComUserName(username);
465468
// Re-unify the user
@@ -475,14 +478,7 @@ public void refreshMetadata(boolean isUserConnected, boolean isWordPressComUser,
475478
}
476479
}
477480

478-
try {
479-
JSONObject properties = new JSONObject();
480-
properties.put(JETPACK_USER, isJetpackUser);
481-
properties.put(NUMBER_OF_BLOGS, numBlogs);
482-
mNosaraClient.registerUserProperties(properties);
483-
} catch (JSONException e) {
484-
AppLog.e(AppLog.T.UTILS, e);
485-
}
481+
486482
}
487483

488484

0 commit comments

Comments
 (0)